[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request 115389: mouseclick effect, do not collect clicks while not active
From: "Commit Hook" <null () kde ! org>
Date: 2014-01-30 19:44:35
Message-ID: 20140130194435.21753.62900 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115389/#review48654
-----------------------------------------------------------
This review has been submitted with commit aa179e25bab4b0c3122583c278908513da17a40e \
by Thomas Lübking to branch KDE/4.11.
- Commit Hook
On Jan. 29, 2014, 8:36 p.m., Thomas Lübking wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115389/
> -----------------------------------------------------------
>
> (Updated Jan. 29, 2014, 8:36 p.m.)
>
>
> Review request for kwin and Martin Gräßlin.
>
>
> Bugs: 328010
> http://bugs.kde.org/show_bug.cgi?id=328010
>
>
> Repository: kde-workspace
>
>
> Description
> -------
>
> let's turn this into a proper request ;-)
>
> counter suggest was
>
> void MouseClickEffect::slotMouseChanged(...)
> {
> if (!m_enabled) return;
> ...
>
> objection against this was:
> mouse polling is fired pretty often, so why bind the slot just to exit it on \
> invocation (most of the time)?
>
> Diffs
> -----
>
> kwin/effects/mouseclick/mouseclick.cpp 99b9303
>
> Diff: https://git.reviewboard.kde.org/r/115389/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Thomas Lübking
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/115389/">https://git.reviewboard.kde.org/r/115389/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit aa179e25bab4b0c3122583c278908513da17a40e by Thomas Lübking to \
branch KDE/4.11.</pre> <br />
<p>- Commit Hook</p>
<br />
<p>On January 29th, 2014, 8:36 p.m. UTC, Thomas Lübking wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin and Martin Gräßlin.</div>
<div>By Thomas Lübking.</div>
<p style="color: grey;"><i>Updated Jan. 29, 2014, 8:36 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=328010">328010</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">let's turn this into a proper request ;-)
counter suggest was
void MouseClickEffect::slotMouseChanged(...)
{
if (!m_enabled) return;
...
objection against this was:
mouse polling is fired pretty often, so why bind the slot just to exit it on \
invocation (most of the time)?</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kwin/effects/mouseclick/mouseclick.cpp <span style="color: \
grey">(99b9303)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/115389/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic