'Re: Review Request 111473: add kwin loader script and install binaries suffixed .bin to libexec'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Re: Review Request 111473: add kwin loader script and install binaries suffixed .bin to libexec
From:       Thomas_Lübking <thomas.luebking () gmail ! com>
Date:       2014-01-29 19:41:58
Message-ID: 20140129194158.32672.91268 () probe ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/111473/
-----------------------------------------------------------

(Updated Jan. 29, 2014, 7:41 p.m.)

Status
------

This change has been discarded.

Review request for kwin and Martin Gräßlin.

Repository: kde-workspace

Description
-------

I'm just dropping that here in case and as last resort.
The script might contain too much bash slang.
Fixing FXAA is "heuristic" since it applies whenever a context is created (so \
actually we'd have to do that from the core and whenever initting a GL context - just \
that i'm not very eager to call nvidia-setting everytime)

Suffixing the binaries is required because startkde/ksmserver would find the libexec \
versions of kwin/_gles rather than the /usr/bin one. Also it prevents us from shell \
bombs when we'd resolve ourself (because no kwin binary was installed)

Suggested strategy for distros was to make this a third package when they want to \
install kwin and kwin_gles independently.

Diffs
-----

  kwin/CMakeLists.txt 9d9cae3 
  kwin/kwin PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/111473/diff/

Testing
-------

Works as long as sh is some sort of bash/dash/zsh.

Thanks,

Thomas Lübking

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/111473/">https://git.reviewboard.kde.org/r/111473/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray \
solid;">  <tr>
  <td>
   <h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been \
discarded.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kwin and Martin Gräßlin.</div>
<div>By Thomas Lübking.</div>

<p style="color: grey;"><i>Updated Jan. 29, 2014, 7:41 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-workspace
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I&#39;m just dropping that here in case and as last resort. The script \
might contain too much bash slang. Fixing FXAA is &quot;heuristic&quot; since it \
applies whenever a context is created (so actually we&#39;d have to do that from the \
core and whenever initting a GL context - just that i&#39;m not very eager to call \
nvidia-setting everytime)

Suffixing the binaries is required because startkde/ksmserver would find the libexec \
versions of kwin/_gles rather than the /usr/bin one. Also it prevents us from shell \
bombs when we&#39;d resolve ourself (because no kwin binary was installed)

Suggested strategy for distros was to make this a third package when they want to \
install kwin and kwin_gles independently.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Works as long as sh is some sort of bash/dash/zsh.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kwin/CMakeLists.txt <span style="color: grey">(9d9cae3)</span></li>

 <li>kwin/kwin <span style="color: grey">(PRE-CREATION)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/111473/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin

[prev in list] [next in list] [prev in thread] [next in thread] 