[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request 110642: new take on buffer age support
From: Thomas_Lübking <thomas.luebking () gmail ! com>
Date: 2014-01-29 19:40:06
Message-ID: 20140129194006.32672.76286 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/110642/
-----------------------------------------------------------
(Updated Jan. 29, 2014, 7:40 p.m.)
Status
------
This change has been discarded.
Review request for kwin, Martin Gräßlin and Ralf Jung.
Repository: kde-workspace
Description
-------
On top of https://git.reviewboard.kde.org/r/110556/ and \
https://git.reviewboard.kde.org/r/110558/
Issues:
- show paint becomes useless (because the mark of the previous frames is included)
- too much abstraction imo (from scene to scene_opengl to backend)
- we'll require a nice hint to effects on what is actually repainted, because otherwise \
BE::Clock will superimpose ;-P
- in the "only when cheap" vsync mode, this requires n fullscreen updates to take off (ie. one \
additional for triple buffering to have two altogether)
- i really don't like how extending and marking interact and would prefer to handle that in one \
function that's also called from the complex scene path.
Diffs
-----
kwin/effects.h 4115433
kwin/effects.cpp be0eb54
kwin/glxbackend.cpp 7bfceee
kwin/libkwineffects/kwineffects.h f0bc22a
kwin/libkwineffects/kwinglutils_funcs.h d6a2cd1
kwin/options.h 3ac9947
kwin/options.cpp 03203ef
kwin/scene.h c96065d
kwin/scene.cpp b1142d0
kwin/scene_opengl.h 6c78909
kwin/scene_opengl.cpp 3035763
Diff: https://git.reviewboard.kde.org/r/110642/diff/
Testing
-------
Thanks,
Thomas Lübking
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/110642/">https://git.reviewboard.kde.org/r/110642/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray solid;">
<tr>
<td>
<h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been \
discarded.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black solid;"> <tr>
<td>
<div>Review request for kwin, Martin Gräßlin and Ralf Jung.</div>
<div>By Thomas Lübking.</div>
<p style="color: grey;"><i>Updated Jan. 29, 2014, 7:40 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px \
solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">On top of \
https://git.reviewboard.kde.org/r/110556/ and https://git.reviewboard.kde.org/r/110558/
Issues:
- show paint becomes useless (because the mark of the previous frames is included)
- too much abstraction imo (from scene to scene_opengl to backend)
- we'll require a nice hint to effects on what is actually repainted, because otherwise \
BE::Clock will superimpose ;-P
- in the "only when cheap" vsync mode, this requires n fullscreen updates to take off \
(ie. one additional for triple buffering to have two altogether)
- i really don't like how extending and marking interact and would prefer to handle that in \
one function that's also called from the complex scene path.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kwin/effects.h <span style="color: grey">(4115433)</span></li>
<li>kwin/effects.cpp <span style="color: grey">(be0eb54)</span></li>
<li>kwin/glxbackend.cpp <span style="color: grey">(7bfceee)</span></li>
<li>kwin/libkwineffects/kwineffects.h <span style="color: grey">(f0bc22a)</span></li>
<li>kwin/libkwineffects/kwinglutils_funcs.h <span style="color: grey">(d6a2cd1)</span></li>
<li>kwin/options.h <span style="color: grey">(3ac9947)</span></li>
<li>kwin/options.cpp <span style="color: grey">(03203ef)</span></li>
<li>kwin/scene.h <span style="color: grey">(c96065d)</span></li>
<li>kwin/scene.cpp <span style="color: grey">(b1142d0)</span></li>
<li>kwin/scene_opengl.h <span style="color: grey">(6c78909)</span></li>
<li>kwin/scene_opengl.cpp <span style="color: grey">(3035763)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/110642/diff/" style="margin-left: 3em;">View \
Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic