[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request 114146: hotfix ksnapshot / screenshot effect
From: Thomas_Lübking <thomas.luebking () gmail ! com>
Date: 2014-01-29 19:38:49
Message-ID: 20140129193849.2191.58179 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114146/
-----------------------------------------------------------
(Updated Jan. 29, 2014, 7:38 p.m.)
Status
------
This change has been discarded.
Review request for kwin and Martin Gräßlin.
Bugs: 279615
http://bugs.kde.org/show_bug.cgi?id=279615
Repository: kde-workspace
Description
-------
Hotfix, intercepts closing ksnapshot dialog, then activates itself and suppresses the \
dialog as good as possible until the dialog is deleted.
Drawback is obvious:
The dialog _always_ disappears instantly, whether for a screenshot trigger or not.
Also it will no longer be possible to capture the disappearing ksnapshot window.
NOTICE: that this does not help if you're running ksnapshot w/o the screenshot effect \
(it will xwd whatever is there - just as if you're using any other compositor)
Personal note: I consider the "bug" a complete ebkac.
You capture a screen region at a certain time.
If the appearance of the screen region doesn't fit your expectations at that time, \
you got to wait for a better time. Any random delay to deal with what kwin, compiz, \
compton, xcompmgr, metacity, e17 ... might visually do with the screen on any event \
*cannot* work.
In the long run, ksnapshot might offer an extra "All Windows" when the screenshot \
effect is available which draws the window stack (minus ksnapshot) at the actual \
positions and values (no transformations at all)
Diffs
-----
kwin/effects/screenshot/screenshot.h 4ee138c
kwin/effects/screenshot/screenshot.cpp 8390716
Diff: https://git.reviewboard.kde.org/r/114146/diff/
Testing
-------
faded out 6s, tested w/ and w/o patch, ensured that "qdbus org.kde.kwin /Effects \
activeEffects" does usually not include the effect.
Thanks,
Thomas Lübking
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/114146/">https://git.reviewboard.kde.org/r/114146/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray \
solid;"> <tr>
<td>
<h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been \
discarded.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin and Martin Gräßlin.</div>
<div>By Thomas Lübking.</div>
<p style="color: grey;"><i>Updated Jan. 29, 2014, 7:38 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=279615">279615</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Hotfix, intercepts closing ksnapshot dialog, then activates itself and \
suppresses the dialog as good as possible until the dialog is deleted.
Drawback is obvious:
The dialog _always_ disappears instantly, whether for a screenshot trigger or not.
Also it will no longer be possible to capture the disappearing ksnapshot window.
NOTICE: that this does not help if you're running ksnapshot w/o the screenshot \
effect (it will xwd whatever is there - just as if you're using any other \
compositor)
Personal note: I consider the "bug" a complete ebkac.
You capture a screen region at a certain time.
If the appearance of the screen region doesn't fit your expectations at that \
time, you got to wait for a better time. Any random delay to deal with what kwin, \
compiz, compton, xcompmgr, metacity, e17 ... might visually do with the screen on any \
event *cannot* work.
In the long run, ksnapshot might offer an extra "All Windows" when the \
screenshot effect is available which draws the window stack (minus ksnapshot) at the \
actual positions and values (no transformations at all)</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">faded out 6s, tested w/ and w/o patch, ensured that "qdbus \
org.kde.kwin /Effects activeEffects" does usually not include the effect. </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kwin/effects/screenshot/screenshot.h <span style="color: \
grey">(4ee138c)</span></li>
<li>kwin/effects/screenshot/screenshot.cpp <span style="color: \
grey">(8390716)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/114146/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic