'Re: Review Request 115306: merge buffer_age render into general render code'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Re: Review Request 115306: merge buffer_age render into general render code
From:       Thomas_Lübking <thomas.luebking () gmail ! com>
Date:       2014-01-29 19:22:40
Message-ID: 20140129192240.2191.25382 () probe ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115306/
-----------------------------------------------------------

(Updated Jan. 29, 2014, 7:22 p.m.)

Status
------

This change has been marked as submitted.

Review request for kwin, Fredrik Höglund and Martin Gräßlin.

Bugs: 329821
    http://bugs.kde.org/show_bug.cgi?id=329821

Repository: kde-workspace

Description
-------

avoiding the blocking swapinterval detection causes
issues in the timing strategy and prevents protection
against CPU overload on the nvidia blob

--
I don't know whether we need the waitsync in other swap cases or in general but \
stuffed it into a branch avoided on bufferAge support

Diffs
-----

  kwin/eglonxbackend.cpp dd41da5 
  kwin/glxbackend.cpp 73f463e 

Diff: https://git.reviewboard.kde.org/r/115306/diff/

Testing
-------

triple buffer detection re-logged, correct timing strategy set.

Thanks,

Thomas Lübking

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/115306/">https://git.reviewboard.kde.org/r/115306/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray \
solid;">  <tr>
  <td>
   <h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been \
marked as submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kwin, Fredrik Höglund and Martin Gräßlin.</div>
<div>By Thomas Lübking.</div>

<p style="color: grey;"><i>Updated Jan. 29, 2014, 7:22 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=329821">329821</a>

</div>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-workspace
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">avoiding the blocking swapinterval detection causes issues in the timing \
strategy and prevents protection against CPU overload on the nvidia blob

--
I don&#39;t know whether we need the waitsync in other swap cases or in general but \
stuffed it into a branch avoided on bufferAge support</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">triple buffer detection re-logged, correct timing strategy set.</pre>  \
</td>  </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kwin/eglonxbackend.cpp <span style="color: grey">(dd41da5)</span></li>

 <li>kwin/glxbackend.cpp <span style="color: grey">(73f463e)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/115306/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin

[prev in list] [next in list] [prev in thread] [next in thread] 