From kwin Wed Jan 29 19:22:40 2014 From: =?utf-8?q?Thomas_L=C3=BCbking?= Date: Wed, 29 Jan 2014 19:22:40 +0000 To: kwin Subject: Re: Review Request 114963: fix session restorage as much as possible Message-Id: <20140129192240.32672.94810 () probe ! kde ! org> X-MARC-Message: https://marc.info/?l=kwin&m=139102339211859 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============1245701039893901110==" --===============1245701039893901110== Content-Type: multipart/alternative; boundary="===============1306481485419945310==" --===============1306481485419945310== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114963/ ----------------------------------------------------------- (Updated Jan. 29, 2014, 7:22 p.m.) Status ------ This change has been marked as submitted. Review request for kwin and Martin Gräßlin. Bugs: 326893 http://bugs.kde.org/show_bug.cgi?id=326893 Repository: kde-workspace Description ------- commit 67d0d46836bacf149f9d48a657a8c2b0a0a5ac45 Date: Sat Jan 11 12:52:10 2014 +0100 remove clientMachine from session handling since the hostname is resolved asynchronous, testing it can easily fail CCBUG: 326893 FIXED-IN: 4.11.6 commit c2830e3d99b11288ade61886199391c11f6091c1 Date: Sat Jan 11 12:50:08 2014 +0100 cut spurious \0 byte from string properties added with 26c263cc1de9cf0af66c12d0d746cd8ae7b1744a CCBUG: 326893 FIXED-IN: 4.11.6 Diffs ----- kwin/sm.cpp 1e90eb6 kwin/utils.cpp f725a0e Diff: https://git.reviewboard.kde.org/r/114963/diff/ Testing ------- Chromium back on proper desktop - gimp has the same faulty \0 byte. I expect this and the hostname to cover firefox as well, but didn't test. No idea about pure Qt applications (eg. qupzilla and qt-assistent are not even stored at all) Thanks, Thomas Lübking --===============1306481485419945310== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114963/

This change has been marked as submitted.

Review request for kwin and Martin Gräßlin.
By Thomas Lübking.

Updated Jan. 29, 2014, 7:22 p.m.

Bugs: 326893
Repository: kde-workspace

Description 

commit 67d0d46836bacf149f9d48a657a8c2b0a0a5ac45
Date:   Sat Jan 11 12:52:10 2014 +0100

    remove clientMachine from session handling
    
    since the hostname is resolved asynchronous, testing it can easily fail
    
    CCBUG: 326893
    FIXED-IN: 4.11.6

commit c2830e3d99b11288ade61886199391c11f6091c1
Date:   Sat Jan 11 12:50:08 2014 +0100

    cut spurious \0 byte from string properties
    
    added with 26c263cc1de9cf0af66c12d0d746cd8ae7b1744a
    
    CCBUG: 326893
    FIXED-IN: 4.11.6

Testing 

Chromium back on proper desktop - gimp has the same faulty \0 byte.
I expect this and the hostname to cover firefox as well, but didn't test.

No idea about pure Qt applications (eg. qupzilla and qt-assistent are not even stored at all)

Diffs

  • kwin/sm.cpp (1e90eb6)
  • kwin/utils.cpp (f725a0e)

View Diff
--===============1306481485419945310==-- --===============1245701039893901110== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ kwin mailing list kwin@kde.org https://mail.kde.org/mailman/listinfo/kwin --===============1245701039893901110==--