[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request 114963: fix session restorage as much as possible
From: "Commit Hook" <null () kde ! org>
Date: 2014-01-29 19:22:38
Message-ID: 20140129192238.32672.58864 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114963/#review48569
-----------------------------------------------------------
This review has been submitted with commit 2d156caaf93291514723e3f811d25e534f88ac23 \
by Thomas Lübking to branch KDE/4.11.
- Commit Hook
On Jan. 11, 2014, 11:58 a.m., Thomas Lübking wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114963/
> -----------------------------------------------------------
>
> (Updated Jan. 11, 2014, 11:58 a.m.)
>
>
> Review request for kwin and Martin Gräßlin.
>
>
> Bugs: 326893
> http://bugs.kde.org/show_bug.cgi?id=326893
>
>
> Repository: kde-workspace
>
>
> Description
> -------
>
> commit 67d0d46836bacf149f9d48a657a8c2b0a0a5ac45
> Date: Sat Jan 11 12:52:10 2014 +0100
>
> remove clientMachine from session handling
>
> since the hostname is resolved asynchronous, testing it can easily fail
>
> CCBUG: 326893
> FIXED-IN: 4.11.6
>
> commit c2830e3d99b11288ade61886199391c11f6091c1
> Date: Sat Jan 11 12:50:08 2014 +0100
>
> cut spurious \0 byte from string properties
>
> added with 26c263cc1de9cf0af66c12d0d746cd8ae7b1744a
>
> CCBUG: 326893
> FIXED-IN: 4.11.6
>
>
> Diffs
> -----
>
> kwin/sm.cpp 1e90eb6
> kwin/utils.cpp f725a0e
>
> Diff: https://git.reviewboard.kde.org/r/114963/diff/
>
>
> Testing
> -------
>
> Chromium back on proper desktop - gimp has the same faulty \0 byte.
> I expect this and the hostname to cover firefox as well, but didn't test.
>
> No idea about pure Qt applications (eg. qupzilla and qt-assistent are not even \
> stored at all)
>
> Thanks,
>
> Thomas Lübking
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/114963/">https://git.reviewboard.kde.org/r/114963/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit 2d156caaf93291514723e3f811d25e534f88ac23 by Thomas Lübking to \
branch KDE/4.11.</pre> <br />
<p>- Commit Hook</p>
<br />
<p>On January 11th, 2014, 11:58 a.m. UTC, Thomas Lübking wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin and Martin Gräßlin.</div>
<div>By Thomas Lübking.</div>
<p style="color: grey;"><i>Updated Jan. 11, 2014, 11:58 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=326893">326893</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">commit 67d0d46836bacf149f9d48a657a8c2b0a0a5ac45
Date: Sat Jan 11 12:52:10 2014 +0100
remove clientMachine from session handling
since the hostname is resolved asynchronous, testing it can easily fail
CCBUG: 326893
FIXED-IN: 4.11.6
commit c2830e3d99b11288ade61886199391c11f6091c1
Date: Sat Jan 11 12:50:08 2014 +0100
cut spurious \0 byte from string properties
added with 26c263cc1de9cf0af66c12d0d746cd8ae7b1744a
CCBUG: 326893
FIXED-IN: 4.11.6
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Chromium back on proper desktop - gimp has the same faulty \0 byte. I \
expect this and the hostname to cover firefox as well, but didn't test.
No idea about pure Qt applications (eg. qupzilla and qt-assistent are not even stored \
at all)</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kwin/sm.cpp <span style="color: grey">(1e90eb6)</span></li>
<li>kwin/utils.cpp <span style="color: grey">(f725a0e)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/114963/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic