This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115334/ |
On January 29th, 2014, 3:30 p.m. UTC, Thomas Lübking wrote:
kwin/manage.cpp (Diff revision 2) bool Client::manage(xcb_window_t w, bool isMapped)380 area = workspace()->clientArea(PlacementArea, screens()->current(), desktop());i don't think this is required at all - area is initially determined for the screen, defaulting to active and only overruled by startupinfo or a window rule. instead this makes it impossible to control the screen by user rule for all notifications.On January 29th, 2014, 3:48 p.m. UTC, Martin Klapetek wrote:
Depends if we want to let the user override this. With the exception of the explicit screens passed from some clients, which I intended to work on later, possibly changing this^ in the process. And actually you are correct; it does seem to default to active. So I'll just completely remove this block for now.
The user is enacted to always "know better" by the rules, there's no discrimination - it's his final word. Ie. if the user says "that annoying notification shall please ever appear on screen #1", he's probably a good reason to do so and therefore is right.
- Thomas
On January 29th, 2014, 4:27 p.m. UTC, Martin Klapetek wrote:
Review request for kwin.
By Martin Klapetek.
Updated Jan. 29, 2014, 4:27 p.m.
Repository:
kde-workspace
Description
Testing
Diffs
|