From kwin Wed Jan 29 17:39:05 2014 From: =?utf-8?q?Thomas_L=C3=BCbking?= Date: Wed, 29 Jan 2014 17:39:05 +0000 To: kwin Subject: Re: Review Request 115334: Make KWin place the OSD Message-Id: <20140129173905.2191.54628 () probe ! kde ! org> X-MARC-Message: https://marc.info/?l=kwin&m=139101715509596 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============1178557859307056384==" --===============1178557859307056384== Content-Type: multipart/alternative; boundary="===============3419312751499244183==" --===============3419312751499244183== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit > On Jan. 29, 2014, 3:30 p.m., Thomas Lübking wrote: > > kwin/manage.cpp, line 380 > > > > > > i don't think this is required at all - area is initially determined for the screen, defaulting to active and only overruled by startupinfo or a window rule. > > instead this makes it impossible to control the screen by user rule for all notifications. > > Martin Klapetek wrote: > Depends if we want to let the user override this. With the exception of the explicit screens passed from some clients, which I intended to work on later, possibly changing this^ in the process. > > And actually you are correct; it does seem to default to active. So I'll just completely remove this block for now. The user is enacted to always "know better" by the rules, there's no discrimination - it's his final word. Ie. if the user says "that annoying notification shall please ever appear on screen #1", he's probably a good reason to do so and therefore is right. - Thomas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115334/#review48546 ----------------------------------------------------------- On Jan. 29, 2014, 4:27 p.m., Martin Klapetek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/115334/ > ----------------------------------------------------------- > > (Updated Jan. 29, 2014, 4:27 p.m.) > > > Review request for kwin. > > > Repository: kde-workspace > > > Description > ------- > > Adds a method for placing the OSD window. Currently it simply places it at the lower 2/3 of the screen, has no support yet for staying at a particular screen (like brightness OSD always staying at the controlled screen). Martin said he does not want that in KWin, which I understand, but I'm unsure how else to do it if KWin will do the positioning. Ideas? > > > Diffs > ----- > > kwin/placement.h 7c943ff > kwin/placement.cpp 8534f81 > > Diff: https://git.reviewboard.kde.org/r/115334/diff/ > > > Testing > ------- > > OSD appears where it should. > > > Thanks, > > Martin Klapetek > > --===============3419312751499244183== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115334/

On January 29th, 2014, 3:30 p.m. UTC, Thomas Lübking wrote:

kwin/manage.cpp (Diff revision 2)
bool Client::manage(xcb_window_t w, bool isMapped)
		380	area = workspace()->clientArea(PlacementArea, screens()->current(), desktop());

i don't think this is required at all - area is initially determined for the screen, defaulting to active and only overruled by startupinfo or a window rule.
instead this makes it impossible to control the screen by user rule for all notifications.

On January 29th, 2014, 3:48 p.m. UTC, Martin Klapetek wrote:

Depends if we want to let the user override this. With the exception of the explicit screens passed from some clients, which I intended to work on later, possibly changing this^ in the process.

And actually you are correct; it does seem to default to active. So I'll just completely remove this block for now.

The user is enacted to always "know better" by the rules, there's no discrimination - it's his final word.
Ie. if the user says "that annoying notification shall please ever appear on screen #1", he's probably a good reason to do so and therefore is right.

- Thomas

On January 29th, 2014, 4:27 p.m. UTC, Martin Klapetek wrote:

Review request for kwin.

By Martin Klapetek.

Updated Jan. 29, 2014, 4:27 p.m.

Repository: kde-workspace

Description

Adds a method for placing the OSD window. Currently it simply places it at the lower 2/3 of the screen, has no support yet for staying at a particular screen (like brightness OSD always staying at the controlled screen). Martin said he does not want that in KWin, which I understand, but I'm unsure how else to do it if KWin will do the positioning. Ideas?

Testing

OSD appears where it should.

Diffs

kwin/placement.h (7c943ff)
kwin/placement.cpp (8534f81)

--===============3419312751499244183==-- --===============1178557859307056384== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ kwin mailing list kwin@kde.org https://mail.kde.org/mailman/listinfo/kwin --===============1178557859307056384==--