[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request 115334: Make KWin place the OSD
From: "Martin Klapetek" <martin.klapetek () gmail ! com>
Date: 2014-01-29 16:27:33
Message-ID: 20140129162733.2191.4875 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115334/
-----------------------------------------------------------
(Updated Jan. 29, 2014, 5:27 p.m.)
Review request for kwin.
Repository: kde-workspace
Description
-------
Adds a method for placing the OSD window. Currently it simply places it at the lower \
2/3 of the screen, has no support yet for staying at a particular screen (like \
brightness OSD always staying at the controlled screen). Martin said he does not want \
that in KWin, which I understand, but I'm unsure how else to do it if KWin will do \
the positioning. Ideas?
Diffs (updated)
-----
kwin/placement.h 7c943ff
kwin/placement.cpp 8534f81
Diff: https://git.reviewboard.kde.org/r/115334/diff/
Testing
-------
OSD appears where it should.
Thanks,
Martin Klapetek
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/115334/">https://git.reviewboard.kde.org/r/115334/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin.</div>
<div>By Martin Klapetek.</div>
<p style="color: grey;"><i>Updated Jan. 29, 2014, 5:27 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Adds a method for placing the OSD window. Currently it simply places it \
at the lower 2/3 of the screen, has no support yet for staying at a particular screen \
(like brightness OSD always staying at the controlled screen). Martin said he does \
not want that in KWin, which I understand, but I'm unsure how else to do it if \
KWin will do the positioning. Ideas?</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">OSD appears where it should.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">
<li>kwin/placement.h <span style="color: grey">(7c943ff)</span></li>
<li>kwin/placement.cpp <span style="color: grey">(8534f81)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/115334/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic