This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115297/

This change has been marked as submitted.


Review request for kwin.
By Martin Gräßlin.

Updated Jan. 28, 2014, 6:45 a.m.

Repository: kde-workspace

Description

Keep KWin responsive while loading all effects

Loading all effects during startup can take some time[1] and during
that time the screen is frozen as the loading blocks the compositor.

This change doesn't load effects directly but puts them into a queue.
The loading is controlled by a single-shooting QTimer with 0 msec
interval. Thus we get a firing compositing timer in between and can
ensure that a frame is rendered when needed and also react to X events
during the loading.

[1] On my high-end system the set of effects I use take about 200 msec
    to load.

Testing

Added some debug statements to see whether we get frames rendered between loading. Yes, works.

Diffs

  • kwin/effects.cpp (7da54f4992fcc23989a99e60ec57bcb97c3cc0c3)
  • kwin/effects.h (adcf970a43745cbd44f2510bc0da23aa0450637b)

View Diff