'Re: Review Request 115297: Keep KWin responsive while loading all effects'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Re: Review Request 115297: Keep KWin responsive while loading all effects
From:       "Commit Hook" <null () kde ! org>
Date:       2014-01-28 6:45:16
Message-ID: 20140128064516.26257.16871 () probe ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115297/#review48442
-----------------------------------------------------------

This review has been submitted with commit d3fa39a40384fc371f05c1662e6eb96a4b1e1e1e \
by Martin Gräßlin to branch master.

- Commit Hook

On Jan. 27, 2014, 6:49 a.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115297/
> -----------------------------------------------------------
> 
> (Updated Jan. 27, 2014, 6:49 a.m.)
> 
> 
> Review request for kwin.
> 
> 
> Repository: kde-workspace
> 
> 
> Description
> -------
> 
> Keep KWin responsive while loading all effects
> 
> Loading all effects during startup can take some time[1] and during
> that time the screen is frozen as the loading blocks the compositor.
> 
> This change doesn't load effects directly but puts them into a queue.
> The loading is controlled by a single-shooting QTimer with 0 msec
> interval. Thus we get a firing compositing timer in between and can
> ensure that a frame is rendered when needed and also react to X events
> during the loading.
> 
> [1] On my high-end system the set of effects I use take about 200 msec
> to load.
> 
> 
> Diffs
> -----
> 
> kwin/effects.cpp 7da54f4992fcc23989a99e60ec57bcb97c3cc0c3 
> kwin/effects.h adcf970a43745cbd44f2510bc0da23aa0450637b 
> 
> Diff: https://git.reviewboard.kde.org/r/115297/diff/
> 
> 
> Testing
> -------
> 
> Added some debug statements to see whether we get frames rendered between loading. \
> Yes, works. 
> 
> Thanks,
> 
> Martin Gräßlin
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/115297/">https://git.reviewboard.kde.org/r/115297/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit d3fa39a40384fc371f05c1662e6eb96a4b1e1e1e by Martin Gräßlin to \
branch master.</pre>  <br />

<p>- Commit Hook</p>

<br />
<p>On January 27th, 2014, 6:49 a.m. UTC, Martin Gräßlin wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kwin.</div>
<div>By Martin Gräßlin.</div>

<p style="color: grey;"><i>Updated Jan. 27, 2014, 6:49 a.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-workspace
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Keep KWin responsive while loading all effects

Loading all effects during startup can take some time[1] and during
that time the screen is frozen as the loading blocks the compositor.

This change doesn&#39;t load effects directly but puts them into a queue.
The loading is controlled by a single-shooting QTimer with 0 msec
interval. Thus we get a firing compositing timer in between and can
ensure that a frame is rendered when needed and also react to X events
during the loading.

[1] On my high-end system the set of effects I use take about 200 msec
    to load.</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Added some debug statements to see whether we get frames rendered \
between loading. Yes, works.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kwin/effects.cpp <span style="color: \
grey">(7da54f4992fcc23989a99e60ec57bcb97c3cc0c3)</span></li>

 <li>kwin/effects.h <span style="color: \
grey">(adcf970a43745cbd44f2510bc0da23aa0450637b)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/115297/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin

[prev in list] [next in list] [prev in thread] [next in thread] 