'Re: Review Request 113885: 3 types of blur'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Re: Review Request 113885: 3 types of blur
From:       "Marco Martin" <notmart () gmail ! com>
Date:       2014-01-25 14:23:27
Message-ID: 20140125142327.10270.46752 () probe ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/113885/
-----------------------------------------------------------

(Updated Jan. 25, 2014, 2:23 p.m.)

Status
------

This change has been discarded.

Review request for kdelibs and kwin.

Repository: kdelibs

Description
-------

To enhance readability, not only blur the background, but if the right x property is \
provided, either make the color of the pixels lighter or darker, decreasing the \
contrast a lot. This is different from just making the window more opaque, since it \
doesn't cover the information about color, but just information about contrast, \
making the end result better looking. This is the kdelibs facing part of \
http://git.reviewboard.kde.org/r/113884/

Diffs
-----

  tier1/kwindowsystem/src/kwindoweffects.h 78195ac 
  tier1/kwindowsystem/src/kwindoweffects_dummy.cpp ce3b9bf 
  tier1/kwindowsystem/src/kwindoweffects_x11.cpp 9e3fba7 

Diff: https://git.reviewboard.kde.org/r/113885/diff/

Testing
-------

Thanks,

Marco Martin

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/113885/">https://git.reviewboard.kde.org/r/113885/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray \
solid;">  <tr>
  <td>
   <h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been \
discarded.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kdelibs and kwin.</div>
<div>By Marco Martin.</div>

<p style="color: grey;"><i>Updated Jan. 25, 2014, 2:23 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kdelibs
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">To enhance readability, not only blur the background, but if the right x \
property is provided, either make the color of the pixels lighter or darker, \
decreasing the contrast a lot. This is different from just making the window more \
opaque, since it doesn&#39;t cover the information about color, but just information \
about contrast, making the end result better looking. This is the kdelibs facing part \
of http://git.reviewboard.kde.org/r/113884/</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>tier1/kwindowsystem/src/kwindoweffects.h <span style="color: \
grey">(78195ac)</span></li>

 <li>tier1/kwindowsystem/src/kwindoweffects_dummy.cpp <span style="color: \
grey">(ce3b9bf)</span></li>

 <li>tier1/kwindowsystem/src/kwindoweffects_x11.cpp <span style="color: \
grey">(9e3fba7)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/113885/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin

[prev in list] [next in list] [prev in thread] [next in thread] 