[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request 113884: 3 different types of blur
From: "Marco Martin" <notmart () gmail ! com>
Date: 2014-01-25 14:23:21
Message-ID: 20140125142321.10270.30867 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/113884/
-----------------------------------------------------------
(Updated Jan. 25, 2014, 2:23 p.m.)
Status
------
This change has been discarded.
Review request for kwin.
Repository: kde-workspace
Description
-------
To enhance readability, not only blur the background, but if the right x property is provided, \
either make the color of the pixels lighter or darker, decreasing the contrast a lot. This is \
different from just making the window more opaque, since it doesn't cover the information about \
color, but just information about contrast, making the end result better looking.
Diffs
-----
kwin/effects/blur/blur.h d12c692
kwin/effects/blur/blur.cpp 9b40281
kwin/effects/blur/blurshader.h 54bde62
kwin/effects/blur/blurshader.cpp 0cd14e1
kwin/libkwineffects/kwineffects.h 82df4c6
kwin/scripting/scriptedeffect.h 8db3b6b4
Diff: https://git.reviewboard.kde.org/r/113884/diff/
Testing
-------
File Attachments
----------------
dadel2.png
https://git.reviewboard.kde.org/media/uploaded/files/2013/11/15/dcf24ad3-4150-47b1-a73f-5e29eac4b820__dadel2.png
Thanks,
Marco Martin
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/113884/">https://git.reviewboard.kde.org/r/113884/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray solid;">
<tr>
<td>
<h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been \
discarded.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black solid;"> <tr>
<td>
<div>Review request for kwin.</div>
<div>By Marco Martin.</div>
<p style="color: grey;"><i>Updated Jan. 25, 2014, 2:23 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px \
solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">To enhance \
readability, not only blur the background, but if the right x property is provided, either make \
the color of the pixels lighter or darker, decreasing the contrast a lot. This is different \
from just making the window more opaque, since it doesn't cover the information about \
color, but just information about contrast, making the end result better looking.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kwin/effects/blur/blur.h <span style="color: grey">(d12c692)</span></li>
<li>kwin/effects/blur/blur.cpp <span style="color: grey">(9b40281)</span></li>
<li>kwin/effects/blur/blurshader.h <span style="color: grey">(54bde62)</span></li>
<li>kwin/effects/blur/blurshader.cpp <span style="color: grey">(0cd14e1)</span></li>
<li>kwin/libkwineffects/kwineffects.h <span style="color: grey">(82df4c6)</span></li>
<li>kwin/scripting/scriptedeffect.h <span style="color: grey">(8db3b6b4)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/113884/diff/" style="margin-left: 3em;">View \
Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<ul>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2013/11/15/dcf24ad3-4150-47b1-a73f-5e29eac4b820__dadel2.png">dadel2.png</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic