[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request 115288: Allow windows to specify that they should not get animated on window clos
From: Thomas_Lübking <thomas.luebking () gmail ! com>
Date: 2014-01-24 16:10:27
Message-ID: 20140124161027.10271.16969 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115288/#review48230
-----------------------------------------------------------
kwin/atoms.cpp
<https://git.reviewboard.kde.org/r/115288/#comment34116>
kde_skip_close_animation
kde_skip_close implies different.
kwin/toplevel.cpp
<https://git.reviewboard.kde.org/r/115288/#comment34115>
isSkippING...?
DOESSkipClose...?
isSkipCloseAnimation asks whether this is an animation that skips closing.
- Thomas Lübking
On Jan. 24, 2014, 11:44 a.m., Martin Gräßlin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115288/
> -----------------------------------------------------------
>
> (Updated Jan. 24, 2014, 11:44 a.m.)
>
>
> Review request for kwin.
>
>
> Bugs: 279615
> http://bugs.kde.org/show_bug.cgi?id=279615
>
>
> Repository: kde-workspace
>
>
> Description
> -------
>
> Allow windows to specify that they should not get animated on window close
>
> By setting the X property _KDE_NET_WM_SKIP_CLOSE_ANIMATION to 1 a window
> can request to be excluded from any close animation. This property is
> read in Toplevel, so that it is available to both Client and Unmanaged.
>
> If the window has this property set the Scene suppresses the paintWindow
> loop of the Deleted. Thus no effect needs to be adjusted. But an effect
> using drawWindow directly would still be able to render the Deleted as
> there is no suppression.
>
> Furthermore the property is passed to the EffectWindow so that an
> Effect can make use of this functionality and not start the animation
> in the first place.
>
>
> Diffs
> -----
>
> kwin/atoms.h 83191f80e50dd823fe51ffeec53d2b074b5520a2
> kwin/atoms.cpp cacea099b15ed4cc1f348b64d9167ff5773d1d2b
> kwin/events.cpp 6956f3479b2cdbbc121d0de1e4d7f2e6cd5334d6
> kwin/libkwineffects/kwineffects.h 475749fc5e5e032d24310d9115d7b560d0538d53
> kwin/libkwineffects/kwineffects.cpp dbd7ebf053fed23491c7e83b2eb8d417707e27df
> kwin/manage.cpp deeee4f917b0b04313453adb72db0750c151d312
> kwin/scene.cpp d13e84b8623f32118e19d1dfa224eaed4f4346b3
> kwin/toplevel.h 08177f2022999e8cd1a2344c4e49ea69afeb8f22
> kwin/toplevel.cpp c40682e8462c8cb205df262710bb07b4d64937bc
> kwin/unmanaged.cpp 7b5437d8155b9a5652f5d705d0fdc08e405f15e5
>
> Diff: https://git.reviewboard.kde.org/r/115288/diff/
>
>
> Testing
> -------
>
> Tested with an adjusted KSnapshot, works like a charm.
>
>
> Thanks,
>
> Martin Gräßlin
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/115288/">https://git.reviewboard.kde.org/r/115288/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/115288/diff/1/?file=235822#file235822line60" \
style="color: black; font-weight: bold; text-decoration: \
underline;">kwin/atoms.cpp</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
">Atoms::Atoms()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">60</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="p">,</span> <span class="n">kde_skip_close</span><span class="p">(</span><span \
class="n">QByteArrayLiteral</span><span class="p">(</span><span \
class="s">"_KDE_NET_WM_SKIP_CLOSE_ANIMATION"</span><span \
class="p">))</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">kde_skip_close_animation kde_skip_close implies different.</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/115288/diff/1/?file=235829#file235829line483" \
style="color: black; font-weight: bold; text-decoration: \
underline;">kwin/toplevel.cpp</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">483</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="kt">bool</span> <span class="n">Toplevel</span><span class="o">::</span><span \
class="n">isSkipCloseAnimation</span><span class="p">()</span> <span \
class="k">const</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">isSkippING...? DOESSkipClose...?
isSkipCloseAnimation asks whether this is an animation that skips closing.</pre>
</div>
<br />
<p>- Thomas Lübking</p>
<br />
<p>On January 24th, 2014, 11:44 a.m. UTC, Martin Gräßlin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin.</div>
<div>By Martin Gräßlin.</div>
<p style="color: grey;"><i>Updated Jan. 24, 2014, 11:44 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=279615">279615</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Allow windows to specify that they should not get animated on window \
close
By setting the X property _KDE_NET_WM_SKIP_CLOSE_ANIMATION to 1 a window
can request to be excluded from any close animation. This property is
read in Toplevel, so that it is available to both Client and Unmanaged.
If the window has this property set the Scene suppresses the paintWindow
loop of the Deleted. Thus no effect needs to be adjusted. But an effect
using drawWindow directly would still be able to render the Deleted as
there is no suppression.
Furthermore the property is passed to the EffectWindow so that an
Effect can make use of this functionality and not start the animation
in the first place.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested with an adjusted KSnapshot, works like a charm.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kwin/atoms.h <span style="color: \
grey">(83191f80e50dd823fe51ffeec53d2b074b5520a2)</span></li>
<li>kwin/atoms.cpp <span style="color: \
grey">(cacea099b15ed4cc1f348b64d9167ff5773d1d2b)</span></li>
<li>kwin/events.cpp <span style="color: \
grey">(6956f3479b2cdbbc121d0de1e4d7f2e6cd5334d6)</span></li>
<li>kwin/libkwineffects/kwineffects.h <span style="color: \
grey">(475749fc5e5e032d24310d9115d7b560d0538d53)</span></li>
<li>kwin/libkwineffects/kwineffects.cpp <span style="color: \
grey">(dbd7ebf053fed23491c7e83b2eb8d417707e27df)</span></li>
<li>kwin/manage.cpp <span style="color: \
grey">(deeee4f917b0b04313453adb72db0750c151d312)</span></li>
<li>kwin/scene.cpp <span style="color: \
grey">(d13e84b8623f32118e19d1dfa224eaed4f4346b3)</span></li>
<li>kwin/toplevel.h <span style="color: \
grey">(08177f2022999e8cd1a2344c4e49ea69afeb8f22)</span></li>
<li>kwin/toplevel.cpp <span style="color: \
grey">(c40682e8462c8cb205df262710bb07b4d64937bc)</span></li>
<li>kwin/unmanaged.cpp <span style="color: \
grey">(7b5437d8155b9a5652f5d705d0fdc08e405f15e5)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/115288/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic