[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request 115298: [kwin] Add better support for Notification windows
From: Thomas_Lübking <thomas.luebking () gmail ! com>
Date: 2014-01-24 15:32:39
Message-ID: 20140124153239.10270.52432 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115298/#review48225
-----------------------------------------------------------
kwin/layers.cpp
<https://git.reviewboard.kde.org/r/115298/#comment34112>
"(l > BelowLayer)"?
(or eventually have a dedicated enum - nogood name at hand, though ;-)
kwin/layers.cpp
<https://git.reviewboard.kde.org/r/115298/#comment34110>
trap: if a notification is set keepAbove, it'll end up in the keepAbove layer, \
below the notification layer - what was rather not intended by setting the flag
- Thomas Lübking
On Jan. 24, 2014, 3:18 p.m., Martin Gräßlin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115298/
> -----------------------------------------------------------
>
> (Updated Jan. 24, 2014, 3:18 p.m.)
>
>
> Review request for kwin.
>
>
> Repository: kde-workspace
>
>
> Description
> -------
>
> [kwin] Add better support for Notification windows
>
> KWin starts to support the Notification window type and has an own
> layer for all notification windows. They are kept above the above
> layer but do not go over active fullscreen windows.
>
>
> Diffs
> -----
>
> kwin/utils.h 4348b98bd423e4a74bb37b0592c1e55919dd6860
> kwin/layers.cpp 21bd4399e83c2ec0a3af33fd905d196b9412c0ba
>
> Diff: https://git.reviewboard.kde.org/r/115298/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Martin Gräßlin
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/115298/">https://git.reviewboard.kde.org/r/115298/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/115298/diff/1/?file=240446#file240446line520" \
style="color: black; font-weight: bold; text-decoration: \
underline;">kwin/layers.cpp</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
">ToplevelList Workspace::constrainedStackingOrder()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">518</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="k">if</span> <span class="p">(</span><span class="o">*</span><span \
class="n">mLayer</span> <span class="o">==</span> <span class="n">ActiveLayer</span> \
<span class="o">&&</span> <span class="p">(</span><span class="n">l</span> \
<span class="o">==</span> <span class="n">NormalLayer</span> <span \
class="o">||</span> <span class="n">l</span> <span class="o">==</span> <span \
class="n">AboveLayer</span><span class="p">))</span></pre></td> <th \
bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">520</font></th> <td bgcolor="#fdfebc" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="k">if</span> <span class="p">(</span><span class="o">*</span><span \
class="n">mLayer</span> <span class="o">==</span> <span class="n">ActiveLayer</span> \
<span class="o">&&</span> <span class="p">(</span><span class="n">l</span> \
<span class="o">==</span> <span class="n">NormalLayer</span> <span \
class="o">||</span> <span class="n">l</span> <span class="o">==</span> <span \
class="n">AboveLayer</span><span class="hl"> </span><span class="o"><span \
class="hl">||</span></span><span class="hl"> </span><span class="n"><span \
class="hl">l</span></span><span class="hl"> </span><span class="o"><span \
class="hl">==</span></span><span class="hl"> </span><span class="n"><span \
class="hl">NotificationLayer</span></span><span class="p">))</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">"(l \
> BelowLayer)"? (or eventually have a dedicated enum - nogood name at hand, \
though ;-)</pre> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/115298/diff/1/?file=240446#file240446line842" \
style="color: black; font-weight: bold; text-decoration: \
underline;">kwin/layers.cpp</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">Layer \
Client::belongsToLayer() const</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">842</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="k">if</span> <span class="p">(</span><span \
class="n">isNotification</span><span class="p">())</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">trap: if a \
notification is set keepAbove, it'll end up in the keepAbove layer, below the \
notification layer - what was rather not intended by setting the flag</pre> </div>
<br />
<p>- Thomas Lübking</p>
<br />
<p>On January 24th, 2014, 3:18 p.m. UTC, Martin Gräßlin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin.</div>
<div>By Martin Gräßlin.</div>
<p style="color: grey;"><i>Updated Jan. 24, 2014, 3:18 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">[kwin] Add better support for Notification windows
KWin starts to support the Notification window type and has an own
layer for all notification windows. They are kept above the above
layer but do not go over active fullscreen windows.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kwin/utils.h <span style="color: \
grey">(4348b98bd423e4a74bb37b0592c1e55919dd6860)</span></li>
<li>kwin/layers.cpp <span style="color: \
grey">(21bd4399e83c2ec0a3af33fd905d196b9412c0ba)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/115298/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic