[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Re: Re: Re: Notes from "New OSD in Plasma 2"
From: Martin Klapetek <martin.klapetek () gmail ! com>
Date: 2014-01-21 16:29:12
Message-ID: CAPLgePo=aP0yUooenC2AtivW8aX+TdLDAuDrw59K2Qbgfrko9w () mail ! gmail ! com
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
On Tue, Jan 21, 2014 at 3:28 PM, Martin Klapetek
<martin.klapetek@gmail.com>wrote:
> On Tue, Jan 21, 2014 at 3:10 PM, Martin Gräßlin <mgraesslin@kde.org>wrote:
>
>> On Tuesday 21 January 2014 14:26:59 Martin Klapetek wrote:
>> > On Tue, Jan 21, 2014 at 8:57 AM, Martin Gräßlin <mgraesslin@kde.org>
>> wrote:
>> > > I had a look and the Plasma side seems fine. You can verify using
>> xprop.
>> > > My
>> > >
>> > > demo dialog got the notification type.
>> >
>> > Hmm...I might have been wrong then, using xprop on the OSD I get
>> >
>> > _NET_WM_WINDOW_TYPE(ATOM) = _KDE_NET_WM_WINDOW_TYPE_OVERRIDE,
>> > _NET_WM_WINDOW_TYPE_NORMAL
>>
>> That's not what I had. My example code which I wrote this morning for
>> testing:
>> http://pastebin.kde.org/phhnfbtda
>>
>> I executed the code using qmlscene. Maybe that makes a difference.
>>
>
> Ok, two things I noticed:
>
> 1) If "visible: true" is not present, the type is never NET::Notification,
> even in your code. Once added, it has proper type.
> 2) This works when executed in qmlscene only, it does not work when
> using KDeclarative::QmlObject for the dialog.
>
> I'll investigate why.
>
Update: windowType for the Dialog is overiden by Qt
(in QXcbWindow::setNetWmWindowFlags). That method (in combination with
window flags) however does not support NET::Notification. Should we extend
that system? Or should we make that method not /replace/ the type but just
add it (would that even work?)? Should we work around that in our code?
Please advise.
Cheers
--
Martin Klapetek | KDE Developer
[Attachment #5 (text/html)]
<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Tue, Jan 21, 2014 \
at 3:28 PM, Martin Klapetek <span dir="ltr"><<a \
href="mailto:martin.klapetek@gmail.com" \
target="_blank">martin.klapetek@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px \
0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div \
dir="ltr"><div class="gmail_extra"><div class="gmail_quote">
<div class="im">On Tue, Jan 21, 2014 at 3:10 PM, Martin Gräßlin <span \
dir="ltr"><<a href="mailto:mgraesslin@kde.org" \
target="_blank">mgraesslin@kde.org</a>></span> wrote:<br> <blockquote \
class="gmail_quote" style="margin:0px 0px 0px \
0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div>On \
Tuesday 21 January 2014 14:26:59 Martin Klapetek wrote:<br>
> On Tue, Jan 21, 2014 at 8:57 AM, Martin Gräßlin <<a \
href="mailto:mgraesslin@kde.org" target="_blank">mgraesslin@kde.org</a>> \
wrote:<br> > > I had a look and the Plasma side seems fine. You can verify \
using xprop.<br> > > My<br>
> ><br>
> > demo dialog got the notification type.<br>
><br>
> Hmm...I might have been wrong then, using xprop on the OSD I get<br>
><br>
> _NET_WM_WINDOW_TYPE(ATOM) = _KDE_NET_WM_WINDOW_TYPE_OVERRIDE,<br>
> _NET_WM_WINDOW_TYPE_NORMAL<br>
<br>
</div>That's not what I had. My example code which I wrote this morning for \
testing:<br> <a href="http://pastebin.kde.org/phhnfbtda" \
target="_blank">http://pastebin.kde.org/phhnfbtda</a><br> <br>
I executed the code using qmlscene. Maybe that makes a \
difference.<br></blockquote><div><br></div></div><div>Ok, two things I noticed: \
</div><div><br></div><div>1) If "visible: true" is not present, the type is \
never NET::Notification, even in your code. Once added, it has proper type.</div>
<div>2) This works when executed in qmlscene only, it does not work when using \
KDeclarative::QmlObject for the dialog.</div><div><br></div><div>I'll investigate \
why.</div></div></div></div></blockquote><div><br></div>
<div>Update: windowType for the Dialog is overiden by Qt (in \
QXcbWindow::setNetWmWindowFlags). That method (in combination with window flags) \
however does not support NET::Notification. Should we extend that system? Or should \
we make that method not /replace/ the type but just add it (would that even work?)? \
Should we work around that in our code?</div>
<div><br></div><div>Please advise.</div><div><br></div></div><div>Cheers</div>-- \
<br><div><span style="color:rgb(102,102,102)">Martin Klapetek | KDE \
Developer</span></div> </div></div>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic