[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request 114423: Kwin options : KF5 Port
From: "Laurent Navet" <laurent.navet+kde () gmail ! com>
Date: 2014-01-21 14:37:45
Message-ID: 20140121143745.17756.27432 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Dec. 17, 2013, 7:01 p.m., Martin Gräßlin wrote:
> > I'm not sure whether the change is complete. From the deprecation notice: "since \
> > 5.0, use QGroupBox and QButtonGroup instead". So my understanding is that one has \
> > to create the QButtonGroup from the C++ side.
>
> Laurent Navet wrote:
> My kf5 setup is broken, and don't build for now, as kdelibs has been splitted, I \
> will rebuild all from scratch, but for now it's Christmas time, more time for \
> familly and kids, and less for kde :) Don't expect news before 2 weeks
>
> Martin Gräßlin wrote:
> Have a nice Christmas. It's kind of the same for me - I didn't dare yet to do the \
> rebuild after the splitting.
> Laurent Navet wrote:
> IMHO in this case, replacing KButtonGroup with QGroupBox is correct as KButtonGroup \
> inherits directly from QGroupBox and no calls are made from KButtonGroup methods. \
> If I replace KButtonGroup with QButtonGroup it doesn't compile because of \
> setTitle(), indeed QButtonGroup inherits from QObject and no QWidgets. Tests I've \
> made don't show any regressions. Where is the deprecation notice you talk about ?
> Martin Gräßlin wrote:
> > Where is the deprecation notice you talk about ?
> That's in KButtonGroup in KDE4Support, see \
> http://quickgit.kde.org/?p=kde4support.git&a=blob&h=18a665bba876822c52ac02151412298d \
> 7808f275&hb=5c51e813365e37ae9d4fd5b079b81de75763f060&f=src%2Fkdeui%2Fkbuttongroup.h \
> Thomas Lübking wrote:
> It's however true that KButtonGroup seems pointless (here) - it's basically a \
> groupbox and an index to maintain a "selected" button, which has only even loose \
> meaning on the checking or focus state of the button (a button can be checked but \
> not the selected button and the container does not make buttons implicitly \
> checkable) Looks like the intention was to have a container of exclusively \
> checkable pushbuttons.
> TL;DR - There's been no point in using a KButtonGroup in the first place, just \
> keeping the groupbox container should be perfectly fine.
Martin, did you trust Thomas or should I re add QButtonGroup dependency ?
- Laurent
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114423/#review45882
-----------------------------------------------------------
On Dec. 14, 2013, 2:09 p.m., Laurent Navet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114423/
> -----------------------------------------------------------
>
> (Updated Dec. 14, 2013, 2:09 p.m.)
>
>
> Review request for kwin.
>
>
> Repository: kde-workspace
>
>
> Description
> -------
>
> Replace deprecated KButtonGroup with QGroupBox
>
>
> Diffs
> -----
>
> kwin/kcmkwin/kwinoptions/advanced.ui 8c465b4
> kwin/kcmkwin/kwinoptions/windows.h d82487a
> kwin/kcmkwin/kwinoptions/windows.cpp baf4bfb
>
> Diff: https://git.reviewboard.kde.org/r/114423/diff/
>
>
> Testing
> -------
>
> build and test ok
>
>
> Thanks,
>
> Laurent Navet
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/114423/">https://git.reviewboard.kde.org/r/114423/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On December 17th, 2013, 7:01 p.m. CET, <b>Martin \
Gräßlin</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I'm not sure whether the change is complete. From the deprecation \
notice: "since 5.0, use QGroupBox and QButtonGroup instead". So my \
understanding is that one has to create the QButtonGroup from the C++ side.</pre> \
</blockquote>
<p>On December 19th, 2013, 11:02 a.m. CET, <b>Laurent Navet</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">My kf5 setup is broken, \
and don't build for now, as kdelibs has been splitted, I will rebuild all from \
scratch, but for now it's Christmas time, more time for familly and kids, and \
less for kde :) Don't expect news before 2 weeks</pre>
</blockquote>
<p>On December 19th, 2013, 12:45 p.m. CET, <b>Martin Gräßlin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Have a nice Christmas. \
It's kind of the same for me - I didn't dare yet to do the rebuild after the \
splitting.</pre> </blockquote>
<p>On January 5th, 2014, 9:31 p.m. CET, <b>Laurent Navet</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">IMHO in this case, \
replacing KButtonGroup with QGroupBox is correct as KButtonGroup inherits directly \
from QGroupBox and no calls are made from KButtonGroup methods. If I replace \
KButtonGroup with QButtonGroup it doesn't compile because of setTitle(), indeed \
QButtonGroup inherits from QObject and no QWidgets. Tests I've made don't \
show any regressions. Where is the deprecation notice you talk about ?</pre> \
</blockquote>
<p>On January 8th, 2014, 10:47 a.m. CET, <b>Martin Gräßlin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">> Where is the \
deprecation notice you talk about ? That's in KButtonGroup in KDE4Support, see \
http://quickgit.kde.org/?p=kde4support.git&a=blob&h=18a665bba876822c52ac021514 \
12298d7808f275&hb=5c51e813365e37ae9d4fd5b079b81de75763f060&f=src%2Fkdeui%2Fkbuttongroup.h</pre>
</blockquote>
<p>On January 8th, 2014, 1:01 p.m. CET, <b>Thomas Lübking</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It's however true \
that KButtonGroup seems pointless (here) - it's basically a groupbox and an index \
to maintain a "selected" button, which has only even loose meaning on the \
checking or focus state of the button (a button can be checked but not the selected \
button and the container does not make buttons implicitly checkable) Looks like the \
intention was to have a container of exclusively checkable pushbuttons.
TL;DR - There's been no point in using a KButtonGroup in the first place, just \
keeping the groupbox container should be perfectly fine.</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Martin, did you trust \
Thomas or should I re add QButtonGroup dependency ?</pre> <br />
<p>- Laurent</p>
<br />
<p>On December 14th, 2013, 2:09 p.m. CET, Laurent Navet wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin.</div>
<div>By Laurent Navet.</div>
<p style="color: grey;"><i>Updated Dec. 14, 2013, 2:09 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Replace deprecated KButtonGroup with QGroupBox</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">build and test ok</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kwin/kcmkwin/kwinoptions/advanced.ui <span style="color: \
grey">(8c465b4)</span></li>
<li>kwin/kcmkwin/kwinoptions/windows.h <span style="color: \
grey">(d82487a)</span></li>
<li>kwin/kcmkwin/kwinoptions/windows.cpp <span style="color: \
grey">(baf4bfb)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/114423/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic