[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request 115150: Remove kde4support from data/update_default_rules.cpp
From: Martin_Gräßlin <mgraesslin () kde ! org>
Date: 2014-01-20 15:03:47
Message-ID: 20140120150347.7096.96364 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115150/#review47790
-----------------------------------------------------------
You could also test the tool. The proper command is listed in one of the update \
files. After executing a new window rule should be listed in the rules dialog (on 5). \
It should be empty currently unless you created a rule manually.
kwin/data/update_default_rules.cpp
<https://git.reviewboard.kde.org/r/115150/#comment33881>
I think that one can just be deleted
- Martin Gräßlin
On Jan. 20, 2014, 3:39 p.m., Bhushan Shah wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115150/
> -----------------------------------------------------------
>
> (Updated Jan. 20, 2014, 3:39 p.m.)
>
>
> Review request for kwin and Martin Gräßlin.
>
>
> Repository: kde-workspace
>
>
> Description
> -------
>
> https://trello.com/c/ckovUAkd/79-remove-kde4support-from-data-update-default-rules-cpp
>
>
> Diffs
> -----
>
> kwin/data/CMakeLists.txt 981ce4b
> kwin/data/update_default_rules.cpp e90c044
>
> Diff: https://git.reviewboard.kde.org/r/115150/diff/
>
>
> Testing
> -------
>
> compiles
>
>
> Thanks,
>
> Bhushan Shah
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/115150/">https://git.reviewboard.kde.org/r/115150/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">You could also test the \
tool. The proper command is listed in one of the update files. After executing a new \
window rule should be listed in the rules dialog (on 5). It should be empty currently \
unless you created a rule manually.</pre> <br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/115150/diff/1/?file=234829#file234829line38" \
style="color: black; font-weight: bold; text-decoration: \
underline;">kwin/data/update_default_rules.cpp</a> <span style="font-weight: \
normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">along \
with this program. If not, see <http://www.gnu.org/licenses/>.</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">38</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">KCmdLineArgs</span><span class="o">::</span><span \
class="n">init</span><span class="p">(</span> <span class="n">argc</span><span \
class="p">,</span> <span class="n">argv</span><span class="p">,</span> <span \
class="o">&</span><span class="n">about</span> <span \
class="p">);</span></pre></td> <th bgcolor="#e9eaa8" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">34</font></th> <td bgcolor="#fdfebc" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; "> <span class="c1">//Q_UNUSED( \
KLocale::global() ); // jump-start locales to get to translated \
descriptions</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I think \
that one can just be deleted</pre> </div>
<br />
<p>- Martin Gräßlin</p>
<br />
<p>On January 20th, 2014, 3:39 p.m. CET, Bhushan Shah wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin and Martin Gräßlin.</div>
<div>By Bhushan Shah.</div>
<p style="color: grey;"><i>Updated Jan. 20, 2014, 3:39 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">https://trello.com/c/ckovUAkd/79-remove-kde4support-from-data-update-default-rules-cpp</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">compiles</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kwin/data/CMakeLists.txt <span style="color: grey">(981ce4b)</span></li>
<li>kwin/data/update_default_rules.cpp <span style="color: \
grey">(e90c044)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/115150/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic