[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request 115125: Fix compilation with clang
From: Martin_Gräßlin <mgraesslin () kde ! org>
Date: 2014-01-19 17:38:31
Message-ID: 20140119173831.13922.98756 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115125/#review47720
-----------------------------------------------------------
Ship it!
That looks much better. Please fix the whitespaces and then feel free to push.
kwin/rules.cpp
<https://git.reviewboard.kde.org/r/115125/#comment33851>
nitpick: trailing whitespace
- Martin Gräßlin
On Jan. 19, 2014, 5:47 p.m., Fabian Kosmale wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115125/
> -----------------------------------------------------------
>
> (Updated Jan. 19, 2014, 5:47 p.m.)
>
>
> Review request for kwin and Martin Gräßlin.
>
>
> Repository: kde-workspace
>
>
> Description
> -------
>
> Without the patch, compilation (with clang 3.3) fails with
> error: return type 'const QString' must match previous return type 'QString' when \
> lambda expression has unspecified explicit return type
> For an explanation why this happens, see \
> https://www.mail-archive.com/llvmbugs@cs.uiuc.edu/msg22245.html. GCC seems to \
> simply remove the const. In the patch I'm using a const_cast<QString &> to make the \
> compiler happy, but maybe creating a new QString and returning that one would be \
> clearer? The QString copy ctor is invoked anyway, as the deduced return type is \
> QString, and the result of the cast is still a reference.
>
> Diffs
> -----
>
> kwin/rules.cpp d09548b
>
> Diff: https://git.reviewboard.kde.org/r/115125/diff/
>
>
> Testing
> -------
>
> It still compiles with GCC; though I couldn't run the unit tests so far.
>
>
> Thanks,
>
> Fabian Kosmale
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/115125/">https://git.reviewboard.kde.org/r/115125/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">That looks much better. \
Please fix the whitespaces and then feel free to push.</pre> <br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/115125/diff/2/?file=234697#file234697line273" \
style="color: black; font-weight: bold; text-decoration: \
underline;">kwin/rules.cpp</a> <span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
Rules::write(KConfigGroup& cfg) const</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">273</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="k">auto</span> <span class="n">colorToString</span> <span class="o">=</span> \
<span class="p">[](</span><span class="k">const</span> <span class="n">QString</span> \
<span class="o">&</span><span class="n">value</span><span class="p">)</span> \
<span class="p"><span class="hl">{</span></span></pre></td> <th bgcolor="#e9eaa8" \
style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">273</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="k">auto</span> <span class="n">colorToString</span> <span class="o">=</span> \
<span class="p">[](</span><span class="k">const</span> <span class="n">QString</span> \
<span class="o">&</span><span class="n">value</span><span class="p">)</span> \
<span class="o"><span class="hl">-></span></span><span class="hl"> </span><span \
class="n"><span class="hl">QString</span></span><span class="hl"> </span><span \
class="p"><span class="hl">{</span></span><span class="hl"><span class="ew"> \
</span></span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">nitpick: \
trailing whitespace</pre> </div>
<br />
<p>- Martin Gräßlin</p>
<br />
<p>On January 19th, 2014, 5:47 p.m. CET, Fabian Kosmale wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin and Martin Gräßlin.</div>
<div>By Fabian Kosmale.</div>
<p style="color: grey;"><i>Updated Jan. 19, 2014, 5:47 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Without the patch, compilation (with clang 3.3) fails \
with
error: return type 'const QString' must match previous return type \
'QString' when lambda expression has unspecified explicit return type
For an explanation why this happens, see \
https://www.mail-archive.com/llvmbugs@cs.uiuc.edu/msg22245.html. GCC seems to simply \
remove the const. In the patch I'm using a const_cast<QString &> to \
make the compiler happy, but maybe creating a new QString and returning that one \
would be clearer? The QString copy ctor is invoked anyway, as the deduced return type \
is QString, and the result of the cast is still a reference.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">It still compiles with GCC; though I couldn't run the unit tests so \
far.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kwin/rules.cpp <span style="color: grey">(d09548b)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/115125/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic