[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request 114803: Replace NULL with nullptr in kcmkwin
From: "Matteo De Carlo" <matteo.dek () gmail ! com>
Date: 2014-01-08 9:33:36
Message-ID: 20140108093336.28120.39710 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114803/
-----------------------------------------------------------
(Updated Jan. 8, 2014, 9:33 a.m.)
Status
------
This change has been marked as submitted.
Review request for kwin and Martin Gräßlin.
Repository: kde-workspace
Description
-------
Completing the task of replacing all NULL to nullptr in all the files in kcmkwin folder
(also substituting some "0" used as nullptr with nullptr)
Diffs
-----
kwin/kcmkwin/kwindecoration/buttons.h 965b6cb
kwin/kcmkwin/kwindecoration/buttonsconfigdialog.h 740a32b
kwin/kcmkwin/kwindecoration/configdialog.h 2f53b4a
kwin/kcmkwin/kwindecoration/configdialog.cpp b06eb1c
kwin/kcmkwin/kwindecoration/decorationmodel.h 58da01a
kwin/kcmkwin/kwindecoration/kwindecoration.h fb70ba0
kwin/kcmkwin/kwindecoration/kwindecoration.cpp 3172d77
kwin/kcmkwin/kwindecoration/preview.h df3ef3b
kwin/kcmkwin/kwindesktop/main.cpp 3d835a1
kwin/kcmkwin/kwinrules/detectwidget.h 4fdd361
kwin/kcmkwin/kwinrules/detectwidget.cpp 723bdee
kwin/kcmkwin/kwinrules/main.cpp 678e25a
kwin/kcmkwin/kwinrules/ruleslist.h 19b8768
kwin/kcmkwin/kwinrules/ruleslist.cpp 842a22a
kwin/kcmkwin/kwinrules/ruleswidget.h 7e0e7b4
kwin/kcmkwin/kwinrules/ruleswidget.cpp ea322ab
kwin/kcmkwin/kwintabbox/layoutpreview.h 0203909
kwin/kcmkwin/kwintabbox/main.cpp 5bda688
Diff: https://git.reviewboard.kde.org/r/114803/diff/
Testing
-------
compiled
Thanks,
Matteo De Carlo
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/114803/">https://git.reviewboard.kde.org/r/114803/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray \
solid;"> <tr>
<td>
<h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been \
marked as submitted.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin and Martin Gräßlin.</div>
<div>By Matteo De Carlo.</div>
<p style="color: grey;"><i>Updated Jan. 8, 2014, 9:33 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Completing the task of replacing all NULL to nullptr in all the files in \
kcmkwin folder (also substituting some "0" used as nullptr with \
nullptr)</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">compiled</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kwin/kcmkwin/kwindecoration/buttons.h <span style="color: \
grey">(965b6cb)</span></li>
<li>kwin/kcmkwin/kwindecoration/buttonsconfigdialog.h <span style="color: \
grey">(740a32b)</span></li>
<li>kwin/kcmkwin/kwindecoration/configdialog.h <span style="color: \
grey">(2f53b4a)</span></li>
<li>kwin/kcmkwin/kwindecoration/configdialog.cpp <span style="color: \
grey">(b06eb1c)</span></li>
<li>kwin/kcmkwin/kwindecoration/decorationmodel.h <span style="color: \
grey">(58da01a)</span></li>
<li>kwin/kcmkwin/kwindecoration/kwindecoration.h <span style="color: \
grey">(fb70ba0)</span></li>
<li>kwin/kcmkwin/kwindecoration/kwindecoration.cpp <span style="color: \
grey">(3172d77)</span></li>
<li>kwin/kcmkwin/kwindecoration/preview.h <span style="color: \
grey">(df3ef3b)</span></li>
<li>kwin/kcmkwin/kwindesktop/main.cpp <span style="color: \
grey">(3d835a1)</span></li>
<li>kwin/kcmkwin/kwinrules/detectwidget.h <span style="color: \
grey">(4fdd361)</span></li>
<li>kwin/kcmkwin/kwinrules/detectwidget.cpp <span style="color: \
grey">(723bdee)</span></li>
<li>kwin/kcmkwin/kwinrules/main.cpp <span style="color: grey">(678e25a)</span></li>
<li>kwin/kcmkwin/kwinrules/ruleslist.h <span style="color: \
grey">(19b8768)</span></li>
<li>kwin/kcmkwin/kwinrules/ruleslist.cpp <span style="color: \
grey">(842a22a)</span></li>
<li>kwin/kcmkwin/kwinrules/ruleswidget.h <span style="color: \
grey">(7e0e7b4)</span></li>
<li>kwin/kcmkwin/kwinrules/ruleswidget.cpp <span style="color: \
grey">(ea322ab)</span></li>
<li>kwin/kcmkwin/kwintabbox/layoutpreview.h <span style="color: \
grey">(0203909)</span></li>
<li>kwin/kcmkwin/kwintabbox/main.cpp <span style="color: grey">(5bda688)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/114803/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic