[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request 114477: Kwin-Compositing-kcm: Add Get-Hot-New-Stuff support
From: Martin_Gräßlin <mgraesslin () kde ! org>
Date: 2014-01-07 9:01:29
Message-ID: 20140107090129.22186.72339 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114477/#review46962
-----------------------------------------------------------
effectconfig.cpp
<https://git.reviewboard.kde.org/r/114477/#comment33515>
I just noticed: we should trigger a rebuild of the model in case the dialog got \
accepted and there are changes
- Martin Gräßlin
On Jan. 5, 2014, 6:24 p.m., Antonis Tsiapaliokas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114477/
> -----------------------------------------------------------
>
> (Updated Jan. 5, 2014, 6:24 p.m.)
>
>
> Review request for kwin.
>
>
> Repository: kwin-compositing-kcm
>
>
> Description
> -------
>
> This patch adds the ghns support to kwin-compositing-kcm.
>
>
> Diffs
> -----
>
> CMakeLists.txt 46b68d5
> effectconfig.h 531cf27
> effectconfig.cpp 42fbec8
> kwineffect.knsrc PRE-CREATION
> model.cpp b71df2e
> qml/Effect.qml 32a9e67
> qml/EffectView.qml 1c9d3a6
>
> Diff: https://git.reviewboard.kde.org/r/114477/diff/
>
>
> Testing
> -------
>
> When i click the button which will open the dialog,
> the dialog opens but there no effects inside. It is empty.
> The following error came out on the terminal.
>
> kcmshell5(10012)/default KNS3::Cache::readRegistry: The file \
> "/home/kokeroulis/.local5/knewstuff3/kwineffect.knsregistry" could not be opened. \
>
> Thanks,
>
> Antonis Tsiapaliokas
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/114477/">https://git.reviewboard.kde.org/r/114477/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/114477/diff/4/?file=230496#file230496line90" \
style="color: black; font-weight: bold; text-decoration: \
underline;">effectconfig.cpp</a> <span style="font-weight: normal;">
(Diff revision 4)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">90</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">QPointer</span><span class="o"><</span><span class="n">KNS3</span><span \
class="o">::</span><span class="n">DownloadDialog</span><span class="o">></span> \
<span class="n">downloadDialog</span> <span class="o">=</span> <span \
class="k">new</span> <span class="n">KNS3</span><span class="o">::</span><span \
class="n">DownloadDialog</span><span class="p">(</span><span \
class="s">"kwineffect.knsrc"</span><span class="p">);</span></pre></td> \
</tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">91</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">downloadDialog</span><span class="o">-></span><span \
class="n">exec</span><span class="p">();</span></pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">92</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> \
</tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">93</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="k">delete</span> <span class="n">downloadDialog</span><span \
class="p">;</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I just \
noticed: we should trigger a rebuild of the model in case the dialog got accepted and \
there are changes</pre> </div>
<br />
<p>- Martin Gräßlin</p>
<br />
<p>On January 5th, 2014, 6:24 p.m. CET, Antonis Tsiapaliokas wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin.</div>
<div>By Antonis Tsiapaliokas.</div>
<p style="color: grey;"><i>Updated Jan. 5, 2014, 6:24 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kwin-compositing-kcm
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch adds the ghns support to kwin-compositing-kcm.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">When i click the button which will open the dialog, the dialog opens but \
there no effects inside. It is empty. The following error came out on the terminal.
kcmshell5(10012)/default KNS3::Cache::readRegistry: The file \
"/home/kokeroulis/.local5/knewstuff3/kwineffect.knsregistry" could not be \
opened.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(46b68d5)</span></li>
<li>effectconfig.h <span style="color: grey">(531cf27)</span></li>
<li>effectconfig.cpp <span style="color: grey">(42fbec8)</span></li>
<li>kwineffect.knsrc <span style="color: grey">(PRE-CREATION)</span></li>
<li>model.cpp <span style="color: grey">(b71df2e)</span></li>
<li>qml/Effect.qml <span style="color: grey">(32a9e67)</span></li>
<li>qml/EffectView.qml <span style="color: grey">(1c9d3a6)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/114477/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic