[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request 114588: Background contrast shader (was: 3 different types of blur)
From: "Marco Martin" <notmart () gmail ! com>
Date: 2014-01-05 17:49:55
Message-ID: 20140105174955.8522.96611 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Jan. 5, 2014, 6:29 a.m., Fredrik Höglund wrote:
> > kwin/effects/backgroundcontrast/contrast.cpp, line 112
> > <https://git.reviewboard.kde.org/r/114588/diff/1/?file=226779#file226779line112>
> >
> > By dividing by 100 here you are storing the values as fixed point numbers with \
> > less than 7 bits of precision for the fraction.
> > Xrender specified 16 bits for the fraction, but this was later found to be \
> > insufficient. It resulted in X being extended to allow IEEE 754 single precision \
> > floats to be stored in properties.
the issue is that i need to pass both those matrices and the mask region, that \
expects longs.. so, the "easy" way was just to pass everything long, otherwise i \
would have to pass both longs and floats in the same property.. i guess interpreting \
the raw data in the correct way would work... seems even uglier tough?
> On Jan. 5, 2014, 6:29 a.m., Fredrik Höglund wrote:
> > kwin/effects/backgroundcontrast/contrast.cpp, line 95
> > <https://git.reviewboard.kde.org/r/114588/diff/1/?file=226779#file226779line95>
> >
> > This is not an ideal way of storing a 4x4 array of floating point values in \
> > memory.
i did that since seems to not be possible to set values in a qmatrix outside its \
constructor? maybe just a single qvector of length 16?
> On Jan. 5, 2014, 6:29 a.m., Fredrik Höglund wrote:
> > kwin/effects/backgroundcontrast/contrast.cpp, line 118
> > <https://git.reviewboard.kde.org/r/114588/diff/1/?file=226779#file226779line118>
> >
> > The color matrix in the shader can't be set here since it can be different for \
> > different windows.
> > You have to use w->setData() to store it in the EffectWindow, and set it when you \
> > render the texture with the shader.
should be added a new role like WindowBackgroundContrastMatrixRole, right?
but in this case, how could it work for draweffectframe?
> On Jan. 5, 2014, 6:29 a.m., Fredrik Höglund wrote:
> > kwin/effects/backgroundcontrast/contrast.cpp, line 154
> > <https://git.reviewboard.kde.org/r/114588/diff/1/?file=226779#file226779line154>
> >
> > This function may need to be updated for this effect.
it may probably be return effects->compositingType() == OpenGL2Compositing ?
(then i don't have much hardware to test on, i just know that works fine with nvidia \
and recent fglrx)
> On Jan. 5, 2014, 6:29 a.m., Fredrik Höglund wrote:
> > kwin/effects/backgroundcontrast/contrast.cpp, line 187
> > <https://git.reviewboard.kde.org/r/114588/diff/1/?file=226779#file226779line187>
> >
> > The effect should not be applied behind the decoration.
how i force removal of decoration area?
> On Jan. 5, 2014, 6:29 a.m., Fredrik Höglund wrote:
> > kwin/effects/backgroundcontrast/contrast.cpp, line 399
> > <https://git.reviewboard.kde.org/r/114588/diff/1/?file=226779#file226779line399>
> >
> > Should the effect be applied behind EffectFrames?
they are things like the box that appear when one filters by name windows in the \
present windows one, right? due to the frame that is used it may make sense to be \
used here too, however since as i noted before, it gives problems since thay aren't \
windows i can't do a setData for their matrix.. so.. better remove paintEffectFrame \
altogether from this effect?
> On Jan. 5, 2014, 6:29 a.m., Fredrik Höglund wrote:
> > kwin/effects/backgroundcontrast/contrast.cpp, line 257
> > <https://git.reviewboard.kde.org/r/114588/diff/1/?file=226779#file226779line257>
> >
> > Since pixels don't depend on neighboring pixels, I'm not sure if we need to \
> > reimplement this method at all.
seems to behave the same without prepaintwindow at all, removed
- Marco
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114588/#review46024
-----------------------------------------------------------
On Dec. 21, 2013, 7:16 p.m., Marco Martin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114588/
> -----------------------------------------------------------
>
> (Updated Dec. 21, 2013, 7:16 p.m.)
>
>
> Review request for kwin and Fredrik Höglund.
>
>
> Repository: kde-workspace
>
>
> Description
> -------
>
> This adds a new kwin effect that makes possible to apply a color transform matrix \
> to an area behind a window, this is an alternative approach, as a separate effect \
> compared to adding this to the blur effect that was attempted previously.
> the second part of the patch is in the repository kwindowsystem, branch \
> mart/kwin/backgroundContrast2 (is still not available on reviewboard) \
> https://projects.kde.org/projects/frameworks/kwindowsystem/repository/show?rev=mart%2Fkwin%2FbackgroundContrast2
>
>
> Diffs
> -----
>
> kwin/effects/CMakeLists.txt d1e2b0d
> kwin/effects/backgroundcontrast/.directory PRE-CREATION
> kwin/effects/backgroundcontrast/CMakeLists.txt PRE-CREATION
> kwin/effects/backgroundcontrast/backgroundcontrast.kdev4 PRE-CREATION
> kwin/effects/backgroundcontrast/contrast.cpp PRE-CREATION
> kwin/effects/backgroundcontrast/contrast.desktop PRE-CREATION
> kwin/effects/backgroundcontrast/contrast.h PRE-CREATION
> kwin/effects/backgroundcontrast/contrast.kcfg PRE-CREATION
> kwin/effects/backgroundcontrast/contrast_config.cpp PRE-CREATION
> kwin/effects/backgroundcontrast/contrast_config.desktop PRE-CREATION
> kwin/effects/backgroundcontrast/contrast_config.h PRE-CREATION
> kwin/effects/backgroundcontrast/contrast_config.ui PRE-CREATION
> kwin/effects/backgroundcontrast/contrastconfig.kcfgc PRE-CREATION
> kwin/effects/backgroundcontrast/contrastshader.h PRE-CREATION
> kwin/effects/backgroundcontrast/contrastshader.cpp PRE-CREATION
> kwin/libkwineffects/kwineffects.h 4cfd955
> kwin/scripting/scriptedeffect.h e642829
>
> Diff: https://git.reviewboard.kde.org/r/114588/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Marco Martin
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/114588/">https://git.reviewboard.kde.org/r/114588/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On January 5th, 2014, 6:29 a.m. UTC, <b>Fredrik \
Höglund</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/114588/diff/1/?file=226779#file226779line95" \
style="color: black; font-weight: bold; text-decoration: \
underline;">kwin/effects/backgroundcontrast/contrast.cpp</a> <span \
style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">95</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">QVector</span><span class="o"><</span><span \
class="n">QVector</span><span class="o"><</span><span class="n">qreal</span><span \
class="o">></span> <span class="o">></span> <span \
class="n">colorTransform</span> <span class="o">=</span> <span \
class="n">QVector</span><span class="o"><</span><span \
class="n">QVector</span><span class="o"><</span><span class="n">qreal</span><span \
class="o">></span> <span class="o">></span><span class="p">(</span><span \
class="mi">4</span><span class="p">);</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This is not an ideal way \
of storing a 4x4 array of floating point values in memory.</pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">i did that \
since seems to not be possible to set values in a qmatrix outside its constructor? \
maybe just a single qvector of length 16?</pre> <br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On January 5th, 2014, 6:29 a.m. UTC, <b>Fredrik \
Höglund</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/114588/diff/1/?file=226779#file226779line112" \
style="color: black; font-weight: bold; text-decoration: \
underline;">kwin/effects/backgroundcontrast/contrast.cpp</a> <span \
style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">112</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="n">colorTransform</span><span class="p">[</span><span \
class="n">j</span><span class="o">/</span><span class="mi">4</span><span \
class="p">][</span><span class="n">j</span><span class="o">%</span><span \
class="mi">4</span><span class="p">]</span> <span class="o">=</span> <span \
class="p">(</span><span class="n">qreal</span><span class="p">)</span><span \
class="n">cardinals</span><span class="p">[</span><span class="n">i</span> <span \
class="o">+</span> <span class="n">j</span><span class="p">]</span> <span \
class="o">/</span> <span class="mi">100</span><span class="p">;</span></pre></td> \
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">By dividing by 100 here \
you are storing the values as fixed point numbers with less than 7 bits of precision \
for the fraction.
Xrender specified 16 bits for the fraction, but this was later found to be \
insufficient. It resulted in X being extended to allow IEEE 754 single precision \
floats to be stored in properties. </pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">the issue \
is that i need to pass both those matrices and the mask region, that expects longs.. \
so, the "easy" way was just to pass everything long, otherwise i would have \
to pass both longs and floats in the same property.. i guess interpreting the raw \
data in the correct way would work... seems even uglier tough?</pre> <br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On January 5th, 2014, 6:29 a.m. UTC, <b>Fredrik \
Höglund</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/114588/diff/1/?file=226779#file226779line118" \
style="color: black; font-weight: bold; text-decoration: \
underline;">kwin/effects/backgroundcontrast/contrast.cpp</a> <span \
style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">118</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">shader</span><span class="o">-></span><span \
class="n">setColorMatrix</span><span class="p">(</span><span \
class="n">colorMatrix</span><span class="p">);</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The color matrix in the \
shader can't be set here since it can be different for different windows.
You have to use w->setData() to store it in the EffectWindow, and set it when you \
render the texture with the shader. </pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">should be \
added a new role like WindowBackgroundContrastMatrixRole, right? but in this case, \
how could it work for draweffectframe? </pre>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On January 5th, 2014, 6:29 a.m. UTC, <b>Fredrik \
Höglund</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/114588/diff/1/?file=226779#file226779line154" \
style="color: black; font-weight: bold; text-decoration: \
underline;">kwin/effects/backgroundcontrast/contrast.cpp</a> <span \
style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">154</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="kt">bool</span> <span class="n">ContrastEffect</span><span \
class="o">::</span><span class="n">enabledByDefault</span><span \
class="p">()</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This function may need \
to be updated for this effect.</pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">it may \
probably be return effects->compositingType() == OpenGL2Compositing ? (then i \
don't have much hardware to test on, i just know that works fine with nvidia and \
recent fglrx)</pre> <br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On January 5th, 2014, 6:29 a.m. UTC, <b>Fredrik \
Höglund</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/114588/diff/1/?file=226779#file226779line187" \
style="color: black; font-weight: bold; text-decoration: \
underline;">kwin/effects/backgroundcontrast/contrast.cpp</a> <span \
style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">187</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="k">if</span> <span class="p">(</span><span class="n">value</span><span \
class="p">.</span><span class="n">isValid</span><span class="p">())</span> <span \
class="p">{</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The effect should not be \
applied behind the decoration.</pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">how i force \
removal of decoration area?</pre> <br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On January 5th, 2014, 6:29 a.m. UTC, <b>Fredrik \
Höglund</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/114588/diff/1/?file=226779#file226779line257" \
style="color: black; font-weight: bold; text-decoration: \
underline;">kwin/effects/backgroundcontrast/contrast.cpp</a> <span \
style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">257</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="kt">void</span> <span class="n">ContrastEffect</span><span \
class="o">::</span><span class="n">prePaintWindow</span><span class="p">(</span><span \
class="n">EffectWindow</span><span class="o">*</span> <span class="n">w</span><span \
class="p">,</span> <span class="n">WindowPrePaintData</span><span \
class="o">&</span> <span class="n">data</span><span class="p">,</span> <span \
class="kt">int</span> <span class="n">time</span><span class="p">)</span></pre></td> \
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Since pixels don't \
depend on neighboring pixels, I'm not sure if we need to reimplement this method \
at all. </pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">seems to \
behave the same without prepaintwindow at all, removed</pre> <br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On January 5th, 2014, 6:29 a.m. UTC, <b>Fredrik \
Höglund</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/114588/diff/1/?file=226779#file226779line399" \
style="color: black; font-weight: bold; text-decoration: \
underline;">kwin/effects/backgroundcontrast/contrast.cpp</a> <span \
style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">399</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="kt">void</span> <span class="n">ContrastEffect</span><span \
class="o">::</span><span class="n">paintEffectFrame</span><span \
class="p">(</span><span class="n">EffectFrame</span> <span class="o">*</span><span \
class="n">frame</span><span class="p">,</span> <span class="n">QRegion</span> <span \
class="n">region</span><span class="p">,</span> <span class="kt">double</span> <span \
class="n">opacity</span><span class="p">,</span> <span class="kt">double</span> <span \
class="n">frameOpacity</span><span class="p">)</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Should the effect be \
applied behind EffectFrames?</pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">they are \
things like the box that appear when one filters by name windows in the present \
windows one, right? due to the frame that is used it may make sense to be used here \
too, however since as i noted before, it gives problems since thay aren't windows \
i can't do a setData for their matrix.. so.. better remove paintEffectFrame \
altogether from this effect?</pre> <br />
<p>- Marco</p>
<br />
<p>On December 21st, 2013, 7:16 p.m. UTC, Marco Martin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin and Fredrik Höglund.</div>
<div>By Marco Martin.</div>
<p style="color: grey;"><i>Updated Dec. 21, 2013, 7:16 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This adds a new kwin effect that makes possible to apply a color \
transform matrix to an area behind a window, this is an alternative approach, as a \
separate effect compared to adding this to the blur effect that was attempted \
previously.
the second part of the patch is in the repository kwindowsystem, branch \
mart/kwin/backgroundContrast2 (is still not available on reviewboard) \
https://projects.kde.org/projects/frameworks/kwindowsystem/repository/show?rev=mart%2Fkwin%2FbackgroundContrast2</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kwin/effects/CMakeLists.txt <span style="color: grey">(d1e2b0d)</span></li>
<li>kwin/effects/backgroundcontrast/.directory <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>kwin/effects/backgroundcontrast/CMakeLists.txt <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>kwin/effects/backgroundcontrast/backgroundcontrast.kdev4 <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>kwin/effects/backgroundcontrast/contrast.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>kwin/effects/backgroundcontrast/contrast.desktop <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>kwin/effects/backgroundcontrast/contrast.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>kwin/effects/backgroundcontrast/contrast.kcfg <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>kwin/effects/backgroundcontrast/contrast_config.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>kwin/effects/backgroundcontrast/contrast_config.desktop <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>kwin/effects/backgroundcontrast/contrast_config.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>kwin/effects/backgroundcontrast/contrast_config.ui <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>kwin/effects/backgroundcontrast/contrastconfig.kcfgc <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>kwin/effects/backgroundcontrast/contrastshader.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>kwin/effects/backgroundcontrast/contrastshader.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>kwin/libkwineffects/kwineffects.h <span style="color: \
grey">(4cfd955)</span></li>
<li>kwin/scripting/scriptedeffect.h <span style="color: grey">(e642829)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/114588/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic