[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request 114026: Efficient clipping of quads
From: Martin_Gräßlin <mgraesslin () kde ! org>
Date: 2014-01-03 9:53:27
Message-ID: 20140103095327.11858.93434 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114026/#review46672
-----------------------------------------------------------
The change looks good to me, just the minor style issue. But I have an additional \
small request: please add documentation to it and also add a unit test. I know the \
current code doesn't have it, but that's not a reason to not improve ;-)
kwin/libkwineffects/kwineffects.cpp
<https://git.reviewboard.kde.org/r/114026/#comment33317>
coding style:
const WindowQuad &quad
if possible also use the new for loop style:
for (const WindowQuad &quad : *this)
- Martin Gräßlin
On Nov. 28, 2013, 8:08 a.m., Raul Fernandes wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114026/
> -----------------------------------------------------------
>
> (Updated Nov. 28, 2013, 8:08 a.m.)
>
>
> Review request for kwin.
>
>
> Repository: kde-workspace
>
>
> Description
> -------
>
> The quads clipping done in sliding popups iterate twice through quads, one in \
> splitAtY and splitAtX functions and another in sliding popups itself. Create the \
> functions to clip the quads directly. It can be used by another effect \
> (kwinanimationeffect ??). An added bonus is that the code in sliding popups are \
> more clear now. No reviews??
>
>
> Diffs
> -----
>
> kwin/effects/slidingpopups/slidingpopups.cpp 22889c5
> kwin/libkwineffects/kwineffects.h 62b0a4f
> kwin/libkwineffects/kwineffects.cpp 3efb07a
>
> Diff: https://git.reviewboard.kde.org/r/114026/diff/
>
>
> Testing
> -------
>
> This patch is recent but I'm running it since yesterday without problems.
>
>
> Thanks,
>
> Raul Fernandes
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/114026/">https://git.reviewboard.kde.org/r/114026/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The change looks good to \
me, just the minor style issue. But I have an additional small request: please add \
documentation to it and also add a unit test. I know the current code doesn't \
have it, but that's not a reason to not improve ;-)</pre> <br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/114026/diff/1/?file=215512#file215512line939" \
style="color: black; font-weight: bold; text-decoration: \
underline;">kwin/libkwineffects/kwineffects.cpp</a> <span style="font-weight: \
normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">939</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">foreach</span> <span class="p">(</span><span class="k">const</span> <span \
class="n">WindowQuad</span> <span class="o">&</span> <span \
class="n">quad</span><span class="p">,</span> <span class="o">*</span><span \
class="k">this</span><span class="p">)</span> <span class="p">{</span></pre></td> \
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">coding \
style: const WindowQuad &quad
if possible also use the new for loop style:
for (const WindowQuad &quad : *this)</pre>
</div>
<br />
<p>- Martin Gräßlin</p>
<br />
<p>On November 28th, 2013, 8:08 a.m. CET, Raul Fernandes wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin.</div>
<div>By Raul Fernandes.</div>
<p style="color: grey;"><i>Updated Nov. 28, 2013, 8:08 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The quads clipping done in sliding popups iterate twice through quads, \
one in splitAtY and splitAtX functions and another in sliding popups itself. Create \
the functions to clip the quads directly. It can be used by another effect \
(kwinanimationeffect ??). An added bonus is that the code in sliding popups are more \
clear now. No reviews??</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch is recent but I'm running it since yesterday without \
problems.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kwin/effects/slidingpopups/slidingpopups.cpp <span style="color: \
grey">(22889c5)</span></li>
<li>kwin/libkwineffects/kwineffects.h <span style="color: \
grey">(62b0a4f)</span></li>
<li>kwin/libkwineffects/kwineffects.cpp <span style="color: \
grey">(3efb07a)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/114026/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic