[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request 112298: Replace NULL with nullptr in kwin effects
From: "Matteo De Carlo" <matteo.dek () gmail ! com>
Date: 2014-01-01 21:58:38
Message-ID: 20140101215838.12724.79287 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/112298/
-----------------------------------------------------------
(Updated Jan. 1, 2014, 10:58 p.m.)
Review request for kwin and Martin Gräßlin.
Changes
-------
patch rebased on master
concatenated lines issue fixed
sorry for the long delay
Repository: kde-workspace
Description
-------
Completing the task of replacing all NULL to nullptr in all the files in effects folder
task here: https://trello.com/c/z0a9UZdd/21-replace-null-with-nullptr
Diffs (updated)
-----
kwin/effects/thumbnailaside/thumbnailaside_config.h 6756672
kwin/effects/trackmouse/trackmouse.cpp 1c86912
kwin/effects/trackmouse/trackmouse_config.h 211990d
kwin/effects/windowgeometry/windowgeometry.cpp 3c20bb2
kwin/effects/windowgeometry/windowgeometry_config.h eaa49c4
kwin/effects/wobblywindows/wobblywindows_config.h cb984c5
kwin/effects/zoom/zoom.cpp 97848ae
kwin/effects/zoom/zoom_config.h b59aa55
kwin/effects/snaphelper/snaphelper.cpp 86dd4b6
kwin/effects/startupfeedback/startupfeedback.cpp d700138
kwin/effects/taskbarthumbnail/taskbarthumbnail.cpp 0321d6a
kwin/effects/thumbnailaside/thumbnailaside.cpp 6a753a4
kwin/effects/desktopgrid/desktopgrid.h a9d5577
kwin/effects/desktopgrid/desktopgrid.cpp 6455c38
kwin/effects/desktopgrid/desktopgrid_config.h 8bd8727
kwin/effects/diminactive/diminactive.cpp 6a4a287
kwin/effects/diminactive/diminactive_config.h c83b431
kwin/effects/flipswitch/flipswitch.cpp 008fd55
kwin/effects/flipswitch/flipswitch_config.h 2c1e0fa
kwin/effects/glide/glide.cpp b133858
kwin/effects/glide/glide_config.h e76e63a
kwin/effects/highlightwindow/highlightwindow.cpp 647b47b
kwin/effects/invert/invert.cpp 03ce15d8
kwin/effects/invert/invert_config.h 1fab78c
kwin/effects/logout/logout.cpp 5e19469
kwin/effects/lookingglass/lookingglass.cpp 31edd1d
kwin/effects/lookingglass/lookingglass_config.h ef81612
kwin/effects/magiclamp/magiclamp.cpp 8595168
kwin/effects/magiclamp/magiclamp_config.h 4f07dd8
kwin/effects/magnifier/magnifier.cpp 1159134
kwin/effects/magnifier/magnifier_config.h f21652a
kwin/effects/mouseclick/mouseclick.cpp a888045
kwin/effects/mouseclick/mouseclick_config.h 028662c
kwin/effects/mousemark/mousemark.cpp ece310f
kwin/effects/mousemark/mousemark_config.h 290c9ad
kwin/effects/presentwindows/presentwindows.h 7565c26
kwin/effects/presentwindows/presentwindows.cpp 5a740ab
kwin/effects/presentwindows/presentwindows_config.h 5e5ca63
kwin/effects/resize/resize.cpp a24e124
kwin/effects/resize/resize_config.h f9742e0
kwin/effects/screenedge/screenedgeeffect.cpp 7b02a56
kwin/effects/screenshot/screenshot.cpp be3c9f0
kwin/effects/sheet/sheet.cpp ee5eddf
kwin/effects/showfps/showfps.cpp 01bce31
kwin/effects/showfps/showfps_config.h 9858d5f
kwin/effects/showpaint/showpaint.cpp 9de4649
kwin/effects/slide/slide.cpp 7ed5408
kwin/effects/slideback/slideback.cpp f280e03
kwin/effects/cube/cube_config.h 378d7e1
kwin/effects/cube/cubeslide.cpp c86d257
kwin/effects/cube/cubeslide_config.h fa7f18d
kwin/effects/dashboard/dashboard.cpp 6e11d6d
kwin/effects/dashboard/dashboard_config.h aaa09d6
kwin/effects/blur/blur_config.h bc33efc
kwin/effects/blur/blurshader.cpp 2172a05
kwin/effects/coverswitch/coverswitch.h 75ebdfb
kwin/effects/coverswitch/coverswitch.cpp 0e2d581
kwin/effects/coverswitch/coverswitch_config.h 7945de2
kwin/effects/cube/cube.cpp 8b01070
Diff: https://git.reviewboard.kde.org/r/112298/diff/
Testing
-------
Thanks,
Matteo De Carlo
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/112298/">https://git.reviewboard.kde.org/r/112298/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin and Martin Gräßlin.</div>
<div>By Matteo De Carlo.</div>
<p style="color: grey;"><i>Updated Jan. 1, 2014, 10:58 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">patch rebased on master
concatenated lines issue fixed
sorry for the long delay</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Completing the task of replacing all NULL to nullptr in all the files in \
effects folder
task here: https://trello.com/c/z0a9UZdd/21-replace-null-with-nullptr</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">
<li>kwin/effects/thumbnailaside/thumbnailaside_config.h <span style="color: \
grey">(6756672)</span></li>
<li>kwin/effects/trackmouse/trackmouse.cpp <span style="color: \
grey">(1c86912)</span></li>
<li>kwin/effects/trackmouse/trackmouse_config.h <span style="color: \
grey">(211990d)</span></li>
<li>kwin/effects/windowgeometry/windowgeometry.cpp <span style="color: \
grey">(3c20bb2)</span></li>
<li>kwin/effects/windowgeometry/windowgeometry_config.h <span style="color: \
grey">(eaa49c4)</span></li>
<li>kwin/effects/wobblywindows/wobblywindows_config.h <span style="color: \
grey">(cb984c5)</span></li>
<li>kwin/effects/zoom/zoom.cpp <span style="color: grey">(97848ae)</span></li>
<li>kwin/effects/zoom/zoom_config.h <span style="color: grey">(b59aa55)</span></li>
<li>kwin/effects/snaphelper/snaphelper.cpp <span style="color: \
grey">(86dd4b6)</span></li>
<li>kwin/effects/startupfeedback/startupfeedback.cpp <span style="color: \
grey">(d700138)</span></li>
<li>kwin/effects/taskbarthumbnail/taskbarthumbnail.cpp <span style="color: \
grey">(0321d6a)</span></li>
<li>kwin/effects/thumbnailaside/thumbnailaside.cpp <span style="color: \
grey">(6a753a4)</span></li>
<li>kwin/effects/desktopgrid/desktopgrid.h <span style="color: \
grey">(a9d5577)</span></li>
<li>kwin/effects/desktopgrid/desktopgrid.cpp <span style="color: \
grey">(6455c38)</span></li>
<li>kwin/effects/desktopgrid/desktopgrid_config.h <span style="color: \
grey">(8bd8727)</span></li>
<li>kwin/effects/diminactive/diminactive.cpp <span style="color: \
grey">(6a4a287)</span></li>
<li>kwin/effects/diminactive/diminactive_config.h <span style="color: \
grey">(c83b431)</span></li>
<li>kwin/effects/flipswitch/flipswitch.cpp <span style="color: \
grey">(008fd55)</span></li>
<li>kwin/effects/flipswitch/flipswitch_config.h <span style="color: \
grey">(2c1e0fa)</span></li>
<li>kwin/effects/glide/glide.cpp <span style="color: grey">(b133858)</span></li>
<li>kwin/effects/glide/glide_config.h <span style="color: \
grey">(e76e63a)</span></li>
<li>kwin/effects/highlightwindow/highlightwindow.cpp <span style="color: \
grey">(647b47b)</span></li>
<li>kwin/effects/invert/invert.cpp <span style="color: grey">(03ce15d8)</span></li>
<li>kwin/effects/invert/invert_config.h <span style="color: \
grey">(1fab78c)</span></li>
<li>kwin/effects/logout/logout.cpp <span style="color: grey">(5e19469)</span></li>
<li>kwin/effects/lookingglass/lookingglass.cpp <span style="color: \
grey">(31edd1d)</span></li>
<li>kwin/effects/lookingglass/lookingglass_config.h <span style="color: \
grey">(ef81612)</span></li>
<li>kwin/effects/magiclamp/magiclamp.cpp <span style="color: \
grey">(8595168)</span></li>
<li>kwin/effects/magiclamp/magiclamp_config.h <span style="color: \
grey">(4f07dd8)</span></li>
<li>kwin/effects/magnifier/magnifier.cpp <span style="color: \
grey">(1159134)</span></li>
<li>kwin/effects/magnifier/magnifier_config.h <span style="color: \
grey">(f21652a)</span></li>
<li>kwin/effects/mouseclick/mouseclick.cpp <span style="color: \
grey">(a888045)</span></li>
<li>kwin/effects/mouseclick/mouseclick_config.h <span style="color: \
grey">(028662c)</span></li>
<li>kwin/effects/mousemark/mousemark.cpp <span style="color: \
grey">(ece310f)</span></li>
<li>kwin/effects/mousemark/mousemark_config.h <span style="color: \
grey">(290c9ad)</span></li>
<li>kwin/effects/presentwindows/presentwindows.h <span style="color: \
grey">(7565c26)</span></li>
<li>kwin/effects/presentwindows/presentwindows.cpp <span style="color: \
grey">(5a740ab)</span></li>
<li>kwin/effects/presentwindows/presentwindows_config.h <span style="color: \
grey">(5e5ca63)</span></li>
<li>kwin/effects/resize/resize.cpp <span style="color: grey">(a24e124)</span></li>
<li>kwin/effects/resize/resize_config.h <span style="color: \
grey">(f9742e0)</span></li>
<li>kwin/effects/screenedge/screenedgeeffect.cpp <span style="color: \
grey">(7b02a56)</span></li>
<li>kwin/effects/screenshot/screenshot.cpp <span style="color: \
grey">(be3c9f0)</span></li>
<li>kwin/effects/sheet/sheet.cpp <span style="color: grey">(ee5eddf)</span></li>
<li>kwin/effects/showfps/showfps.cpp <span style="color: grey">(01bce31)</span></li>
<li>kwin/effects/showfps/showfps_config.h <span style="color: \
grey">(9858d5f)</span></li>
<li>kwin/effects/showpaint/showpaint.cpp <span style="color: \
grey">(9de4649)</span></li>
<li>kwin/effects/slide/slide.cpp <span style="color: grey">(7ed5408)</span></li>
<li>kwin/effects/slideback/slideback.cpp <span style="color: \
grey">(f280e03)</span></li>
<li>kwin/effects/cube/cube_config.h <span style="color: grey">(378d7e1)</span></li>
<li>kwin/effects/cube/cubeslide.cpp <span style="color: grey">(c86d257)</span></li>
<li>kwin/effects/cube/cubeslide_config.h <span style="color: \
grey">(fa7f18d)</span></li>
<li>kwin/effects/dashboard/dashboard.cpp <span style="color: \
grey">(6e11d6d)</span></li>
<li>kwin/effects/dashboard/dashboard_config.h <span style="color: \
grey">(aaa09d6)</span></li>
<li>kwin/effects/blur/blur_config.h <span style="color: grey">(bc33efc)</span></li>
<li>kwin/effects/blur/blurshader.cpp <span style="color: grey">(2172a05)</span></li>
<li>kwin/effects/coverswitch/coverswitch.h <span style="color: \
grey">(75ebdfb)</span></li>
<li>kwin/effects/coverswitch/coverswitch.cpp <span style="color: \
grey">(0e2d581)</span></li>
<li>kwin/effects/coverswitch/coverswitch_config.h <span style="color: \
grey">(7945de2)</span></li>
<li>kwin/effects/cube/cube.cpp <span style="color: grey">(8b01070)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/112298/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic