[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request 113766: Do not reimplement QTimeLine's direction functionality - use it.
From: "Andreas Hartmetz" <ahartmetz () gmail ! com>
Date: 2013-11-13 23:21:08
Message-ID: 20131113232108.10037.39172 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113766/
-----------------------------------------------------------
(Updated Nov. 13, 2013, 11:21 p.m.)
Status
------
This change has been discarded.
Review request for kwin, Martin Gräßlin and Thomas Lübking.
Repository: kde-workspace
Description
-------
An accidental find while looking at performance issues.
Diffs
-----
kwin/effects/magiclamp/magiclamp.h 0a6b0f4
kwin/effects/magiclamp/magiclamp.cpp 90887fd
Diff: http://git.reviewboard.kde.org/r/113766/diff/
Testing
-------
The effect still works.
Thanks,
Andreas Hartmetz
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/113766/">http://git.reviewboard.kde.org/r/113766/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray \
solid;"> <tr>
<td>
<h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been \
discarded.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin, Martin Gräßlin and Thomas Lübking.</div>
<div>By Andreas Hartmetz.</div>
<p style="color: grey;"><i>Updated Nov. 13, 2013, 11:21 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">An accidental find while looking at performance issues.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The effect still works.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kwin/effects/magiclamp/magiclamp.h <span style="color: \
grey">(0a6b0f4)</span></li>
<li>kwin/effects/magiclamp/magiclamp.cpp <span style="color: \
grey">(90887fd)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/113766/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic