[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request 112419: set glsl unsupported on indirect contexts
From: Thomas_Lübking <thomas.luebking () gmail ! com>
Date: 2013-08-31 23:09:04
Message-ID: 20130831230904.15159.96426 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Aug. 31, 2013, 10:52 p.m., Hrvoje Senjan wrote:
> > Obviously a ship it from me ;-)
> > Is the same change also needed in #ifdef KWIN_HAVE_OPENGLES snippet,or fglrx would fail anyway with \
> > GLES?
Neither do indirect contexts support GLES, nor does (afaik) fglrx (so far) support EGL - so that is no \
matter (for now. fglrx + nvidia + egl on wayland will be a whole new adventure =)
- Thomas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112419/#review39041
-----------------------------------------------------------
On Aug. 31, 2013, 10:36 p.m., Thomas Lübking wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112419/
> -----------------------------------------------------------
>
> (Updated Aug. 31, 2013, 10:36 p.m.)
>
>
> Review request for kwin, Fredrik Höglund, Martin Gräßlin, and Hrvoje Senjan.
>
>
> Description
> -------
>
> I don't really understand that as from Hrvoje's glxinfo diff the extensions should not be listed anyway \
> and also the announced GL version is 2.1 and GL_SHADING_LANGUAGE_VERSION should therefore be valid.
> Attached Fredrik in case he knows an answer to this apparent contradiction (GL_ARB_*shader* being in \
> the extension list on an indirect context and still GL_SHADING_LANGUAGE_VERSION being invalid despite \
> GL 2.1) - but in doubt it's just fglrx.
>
> This addresses bug 323527.
> http://bugs.kde.org/show_bug.cgi?id=323527
>
>
> Diffs
> -----
>
> kwin/libkwineffects/kwinglplatform.cpp 3783a21
>
> Diff: http://git.reviewboard.kde.org/r/112419/diff/
>
>
> Testing
> -------
>
> See bug, many thanks to Hrvoje for his constant efforts.
>
>
> Thanks,
>
> Thomas Lübking
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/112419/">http://git.reviewboard.kde.org/r/112419/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On August 31st, 2013, 10:52 p.m. UTC, <b>Hrvoje Senjan</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: \
-o-pre-wrap; word-wrap: break-word;">Obviously a ship it from me ;-) Is the same change also needed in \
#ifdef KWIN_HAVE_OPENGLES snippet,or fglrx would fail anyway with GLES?</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: \
-o-pre-wrap; word-wrap: break-word;">Neither do indirect contexts support GLES, nor does (afaik) fglrx \
(so far) support EGL - so that is no matter (for now. fglrx + nvidia + egl on wayland will be a whole new \
adventure =)</pre> <br />
<p>- Thomas</p>
<br />
<p>On August 31st, 2013, 10:36 p.m. UTC, Thomas Lübking wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black solid;"> <tr>
<td>
<div>Review request for kwin, Fredrik Höglund, Martin Gräßlin, and Hrvoje Senjan.</div>
<div>By Thomas Lübking.</div>
<p style="color: grey;"><i>Updated Aug. 31, 2013, 10:36 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid \
#b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I don't really understand that as from \
Hrvoje's glxinfo diff the extensions should not be listed anyway and also the announced GL version is \
2.1 and GL_SHADING_LANGUAGE_VERSION should therefore be valid.
Attached Fredrik in case he knows an answer to this apparent contradiction (GL_ARB_*shader* being in the \
extension list on an indirect context and still GL_SHADING_LANGUAGE_VERSION being invalid despite GL 2.1) \
- but in doubt it's just fglrx.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">See bug, many thanks to Hrvoje for his \
constant efforts.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=323527">323527</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kwin/libkwineffects/kwinglplatform.cpp <span style="color: grey">(3783a21)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/112419/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic