[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request 112368: KREISCH: fix scheduling repaints
From: "Ralf Jung" <post () ralfj ! de>
Date: 2013-08-30 14:33:16
Message-ID: 20130830143316.25621.89455 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Aug. 30, 2013, 7:40 a.m., Martin Gräßlin wrote:
> > Looks fine to me, though I would like to get Ralf's feedback. And I think there is no hurry as \
> > tagging already happened for the .1
>
> Thomas Lübking wrote:
> No, just by request(?) I KREISCH every RR that's necessarily pointing the 4.11 cycle ;-)
> Can drop that again?
Just to let you know I'm on holidays (quickly checked my mail today) till September 8th, so don't expect \
any reviews from me while I'm still enjoying the Alps ;-)
- Ralf
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112368/#review38909
-----------------------------------------------------------
On Aug. 30, 2013, 1:40 a.m., Thomas Lübking wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112368/
> -----------------------------------------------------------
>
> (Updated Aug. 30, 2013, 1:40 a.m.)
>
>
> Review request for kwin, Martin Gräßlin and Ralf Jung.
>
>
> Description
> -------
>
> repaints caused by effects so far polluted the timing calculations since they started the timer on the \
> old vsync offset
> This (together with undercut timing) lead to multiple frames in the buffer queue, and ultimately to a \
> blocking swap (thus trimple buffering misdetection)
> For unsynced painting, it simply caused wrong timings - leading to "well, kinda around 60Hz - could be \
> 73 just as well".
>
> Diffs
> -----
>
> kwin/composite.cpp 097d085
>
> Diff: http://git.reviewboard.kde.org/r/112368/diff/
>
>
> Testing
> -------
>
> yes
>
>
> Thanks,
>
> Thomas Lübking
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/112368/">http://git.reviewboard.kde.org/r/112368/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On August 30th, 2013, 7:40 a.m. CEST, <b>Martin Gräßlin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: \
-o-pre-wrap; word-wrap: break-word;">Looks fine to me, though I would like to get Ralf's feedback. \
And I think there is no hurry as tagging already happened for the .1</pre> </blockquote>
<p>On August 30th, 2013, 12:26 p.m. CEST, <b>Thomas Lübking</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: \
-o-pre-wrap; word-wrap: break-word;">No, just by request(?) I KREISCH every RR that's necessarily \
pointing the 4.11 cycle ;-) Can drop that again?</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: \
-o-pre-wrap; word-wrap: break-word;">Just to let you know I'm on holidays (quickly checked my mail \
today) till September 8th, so don't expect any reviews from me while I'm still enjoying the Alps \
;-)</pre> <br />
<p>- Ralf</p>
<br />
<p>On August 30th, 2013, 1:40 a.m. CEST, Thomas Lübking wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black solid;"> <tr>
<td>
<div>Review request for kwin, Martin Gräßlin and Ralf Jung.</div>
<div>By Thomas Lübking.</div>
<p style="color: grey;"><i>Updated Aug. 30, 2013, 1:40 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid \
#b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">repaints caused by effects so far polluted \
the timing calculations since they started the timer on the old vsync offset
This (together with undercut timing) lead to multiple frames in the buffer queue, and ultimately to a \
blocking swap (thus trimple buffering misdetection)
For unsynced painting, it simply caused wrong timings - leading to "well, kinda around 60Hz - could \
be 73 just as well".</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">yes</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kwin/composite.cpp <span style="color: grey">(097d085)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/112368/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic