[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request 112298: Replace NULL with nullptr in kwin effects
From: Martin_Gräßlin <mgraesslin () kde ! org>
Date: 2013-08-30 5:38:07
Message-ID: 20130830053807.9866.25934 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112298/#review38908
-----------------------------------------------------------
kwin/effects/highlightwindow/highlightwindow.cpp
<http://git.reviewboard.kde.org/r/112298/#comment28728>
here also the comment adjustment is wrong
kwin/effects/presentwindows/presentwindows.cpp
<http://git.reviewboard.kde.org/r/112298/#comment28725>
This comment adjustment is wrong. Here it doesn't have the meaning of a pointer.
kwin/effects/presentwindows/presentwindows.cpp
<http://git.reviewboard.kde.org/r/112298/#comment28726>
same here
kwin/effects/trackmouse/trackmouse.cpp
<http://git.reviewboard.kde.org/r/112298/#comment28727>
why this change? Please keep the logic and the ! instead of comparing to nullptr
- Martin Gräßlin
On Aug. 26, 2013, 6:06 p.m., Matteo De Carlo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112298/
> -----------------------------------------------------------
>
> (Updated Aug. 26, 2013, 6:06 p.m.)
>
>
> Review request for kwin and Martin Gräßlin.
>
>
> Description
> -------
>
> Completing the task of replacing all NULL to nullptr in all the files in effects folder
>
> task here: https://trello.com/c/z0a9UZdd/21-replace-null-with-nullptr
>
>
> Diffs
> -----
>
> kwin/effects/blur/blur_config.h bc33efc
> kwin/effects/blur/blurshader.cpp ad108f7
> kwin/effects/coverswitch/coverswitch.h 75ebdfb
> kwin/effects/coverswitch/coverswitch.cpp 6170a4a
> kwin/effects/coverswitch/coverswitch_config.h 7945de2
> kwin/effects/cube/cube.cpp a4fc665
> kwin/effects/cube/cube_config.h 378d7e1
> kwin/effects/cube/cubeslide_config.h fa7f18d
> kwin/effects/dashboard/dashboard.cpp e5bf396
> kwin/effects/dashboard/dashboard_config.h aaa09d6
> kwin/effects/desktopgrid/desktopgrid.h a9d5577
> kwin/effects/desktopgrid/desktopgrid.cpp f7f67f5
> kwin/effects/desktopgrid/desktopgrid_config.h 8bd8727
> kwin/effects/diminactive/diminactive.cpp 6a4a287
> kwin/effects/diminactive/diminactive_config.h c83b431
> kwin/effects/flipswitch/flipswitch.cpp 9786ab5
> kwin/effects/flipswitch/flipswitch_config.h 2c1e0fa
> kwin/effects/glide/glide_config.h e76e63a
> kwin/effects/highlightwindow/highlightwindow.cpp 2452b07
> kwin/effects/invert/invert.cpp dd5d9ec
> kwin/effects/invert/invert_config.h 1fab78c
> kwin/effects/logout/logout.cpp 57e9519
> kwin/effects/lookingglass/lookingglass.cpp c5fc23a
> kwin/effects/lookingglass/lookingglass_config.h ef81612
> kwin/effects/magiclamp/magiclamp.cpp 8595168
> kwin/effects/magiclamp/magiclamp_config.h 4f07dd8
> kwin/effects/magnifier/magnifier.cpp 01c8967
> kwin/effects/magnifier/magnifier_config.h f21652a
> kwin/effects/mouseclick/mouseclick.cpp c9c723e
> kwin/effects/mouseclick/mouseclick_config.h 028662c
> kwin/effects/mousemark/mousemark.cpp 5a86a16
> kwin/effects/mousemark/mousemark_config.h 290c9ad
> kwin/effects/presentwindows/presentwindows.h 32f0cf3
> kwin/effects/presentwindows/presentwindows.cpp 37966d9
> kwin/effects/presentwindows/presentwindows_config.h 5e5ca63
> kwin/effects/resize/resize.cpp a24e124
> kwin/effects/resize/resize_config.h f9742e0
> kwin/effects/screenedge/screenedgeeffect.cpp 5e3c9e5
> kwin/effects/screenshot/screenshot.cpp 1ea6cd0
> kwin/effects/showfps/showfps.cpp 1ab7d57
> kwin/effects/showfps/showfps_config.h 9858d5f
> kwin/effects/showpaint/showpaint.cpp 9de4649
> kwin/effects/slide/slide.cpp 7ed5408
> kwin/effects/slideback/slideback.cpp f280e03
> kwin/effects/snaphelper/snaphelper.cpp 86dd4b6
> kwin/effects/taskbarthumbnail/taskbarthumbnail.cpp 7319a93
> kwin/effects/thumbnailaside/thumbnailaside.cpp 895f297
> kwin/effects/thumbnailaside/thumbnailaside_config.h 6756672
> kwin/effects/trackmouse/trackmouse.cpp 0b257ab
> kwin/effects/trackmouse/trackmouse_config.h 211990d
> kwin/effects/windowgeometry/windowgeometry_config.h eaa49c4
> kwin/effects/wobblywindows/wobblywindows_config.h cb984c5
> kwin/effects/zoom/zoom.cpp 1671343
> kwin/effects/zoom/zoom_config.h b59aa55
>
> Diff: http://git.reviewboard.kde.org/r/112298/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Matteo De Carlo
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/112298/">http://git.reviewboard.kde.org/r/112298/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: \
collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: \
4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/112298/diff/1/?file=184840#file184840line147" style="color: black; \
font-weight: bold; text-decoration: underline;">kwin/effects/highlightwindow/highlightwindow.cpp</a> \
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
HighlightWindowEffect::slotPropertyNotify(EffectWindow* w, long a)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">147</font></th> <td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: \
140%; margin: 0; "> <span class="c1">// Purposely clearing highlight by issuing a <span \
class="hl">NULL</span> target</span></pre></td> <th bgcolor="#e9eaa8" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">147</font></th> <td \
bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="c1">// Purposely clearing highlight by issuing a <span class="hl">nullptr</span> \
target</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; \
white-space: -o-pre-wrap; word-wrap: break-word;">here also the comment adjustment is wrong</pre> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: \
collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: \
4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/112298/diff/1/?file=184855#file184855line823" style="color: black; \
font-weight: bold; text-decoration: underline;">kwin/effects/presentwindows/presentwindows.cpp</a> <span \
style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
PresentWindowsEffect::slotPropertyNotify(EffectWindow* w, long a)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">823</font></th> <td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: \
140%; margin: 0; "> <span class="c1">// Purposely ending present windows by issuing a <span \
class="hl">NULL</span> target</span></pre></td> <th bgcolor="#e9eaa8" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">823</font></th> <td \
bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="c1">// Purposely ending present windows by issuing a <span class="hl">nullptr</span> \
target</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; \
white-space: -o-pre-wrap; word-wrap: break-word;">This comment adjustment is wrong. Here it doesn't \
have the meaning of a pointer.</pre> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: \
collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: \
4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/112298/diff/1/?file=184855#file184855line852" style="color: black; \
font-weight: bold; text-decoration: underline;">kwin/effects/presentwindows/presentwindows.cpp</a> <span \
style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
PresentWindowsEffect::slotPropertyNotify(EffectWindow* w, long a)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">852</font></th> <td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: \
140%; margin: 0; "> <span class="c1">// Purposely ending present windows by issuing a <span \
class="hl">NULL</span> target</span></pre></td> <th bgcolor="#e9eaa8" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">852</font></th> <td \
bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="c1">// Purposely ending present windows by issuing a <span class="hl">nullptr</span> \
target</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; \
white-space: -o-pre-wrap; word-wrap: break-word;">same here</pre> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: \
collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: \
4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/112298/diff/1/?file=184870#file184870line200" style="color: black; \
font-weight: bold; text-decoration: underline;">kwin/effects/trackmouse/trackmouse.cpp</a> <span \
style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
TrackMouseEffect::postPaintScreen()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">200</font></th> <td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: \
140%; margin: 0; "> <span class="k">if</span> <span class="p">(</span><span class="o"><span \
class="hl">!</span></span><span class="p">(</span><span class="n">m_texture</span><span \
class="p">[</span><span class="mi">0</span><span class="p">]</span> <span class="o"><span \
class="hl">||</span></span><span class="hl"> </span><span class="n">m_picture</span><span \
class="p">[</span><span class="mi">0</span><span class="p">]))</span> <span class="p">{</span></pre></td> \
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">200</font></th> <td bgcolor="#fdfebc" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; "> <span class="k">if</span> <span class="p">((</span><span \
class="n">m_texture</span><span class="p">[</span><span class="mi">0</span><span class="p">]</span> <span \
class="o"><span class="hl">==</span></span><span class="hl"> </span><span class="n"><span \
class="hl">nullptr</span></span><span class="p"><span class="hl">)</span></span><span class="hl"> \
</span><span class="o"><span class="hl">&&</span></span><span class="hl"> </span><span \
class="p"><span class="hl">(</span></span><span class="n">m_picture</span><span class="p">[</span><span \
class="mi">0</span><span class="p">]</span><span class="hl"> </span><span class="o"><span \
class="hl">==</span></span><span class="hl"> </span><span class="n"><span \
class="hl">nullptr</span></span><span class="p">))</span> <span class="p">{</span></pre></td> </tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">201</font></th> <td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: \
140%; margin: 0; "> <span class="n">loadTexture</span><span class="p">();</span></pre></td> <th \
bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">201</font></th> <td bgcolor="#ffffff" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; "> <span class="n">loadTexture</span><span \
class="p">();</span></pre></td> </tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">202</font></th> <td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: \
140%; margin: 0; "> <span class="k">if</span> <span class="p">(</span><span class="o"><span \
class="hl">!</span></span><span class="p">(</span><span class="n">m_texture</span><span \
class="p">[</span><span class="mi">0</span><span class="p">]</span> <span class="o"><span \
class="hl">||</span></span><span class="hl"> </span><span class="n">m_picture</span><span \
class="p">[</span><span class="mi">0</span><span class="p">]))</span></pre></td> <th bgcolor="#e9eaa8" \
style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">202</font></th> <td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: \
140%; margin: 0; "> <span class="k">if</span> <span class="p">((</span><span \
class="n">m_texture</span><span class="p">[</span><span class="mi">0</span><span class="p">]</span> <span \
class="o"><span class="hl">==</span></span><span class="hl"> </span><span class="n"><span \
class="hl">nullptr</span></span><span class="p"><span class="hl">)</span></span><span class="hl"> \
</span><span class="o"><span class="hl">&&</span></span><span class="hl"> </span><span \
class="p"><span class="hl">(</span></span><span class="n">m_picture</span><span class="p">[</span><span \
class="mi">0</span><span class="p">]</span><span class="hl"> </span><span class="o"><span \
class="hl">==</span></span><span class="hl"> </span><span class="n"><span \
class="hl">nullptr</span></span><span class="p">))</span></pre></td> </tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">203</font></th> <td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: \
140%; margin: 0; "> <span class="k">return</span> <span class="nb">false</span><span \
class="p">;</span></pre></td> <th bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: \
1px solid #C0C0C0;" align="right"><font size="2">203</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">return</span> <span \
class="nb">false</span><span class="p">;</span></pre></td> </tr>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">204</font></th> <td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: \
140%; margin: 0; "> <span class="p">}</span></pre></td> <th bgcolor="#f0f0f0" style="border-left: 1px \
solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">204</font></th> <td \
bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="p">}</span></pre></td> </tr>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">205</font></th> <td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: \
140%; margin: 0; "><span class="cp">#else</span></pre></td> <th bgcolor="#f0f0f0" style="border-left: \
1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">205</font></th> <td \
bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="cp">#else</span></pre></td> </tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">206</font></th> <td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: \
140%; margin: 0; "> <span class="k">if</span> <span class="p">(</span><span class="o"><span \
class="hl">!</span></span><span class="n">m_texture</span><span class="p">[</span><span \
class="mi">0</span><span class="p">])</span> <span class="p">{</span></pre></td> <th bgcolor="#e9eaa8" \
style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">206</font></th> <td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: \
140%; margin: 0; "> <span class="k">if</span> <span class="p">(</span><span \
class="n">m_texture</span><span class="p">[</span><span class="mi">0</span><span class="p">]</span><span \
class="hl"> </span><span class="o"><span class="hl">==</span></span><span class="hl"> </span><span \
class="n"><span class="hl">nullptr</span></span><span class="p">)</span> <span \
class="p">{</span></pre></td> </tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">207</font></th> <td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: \
140%; margin: 0; "> <span class="n">loadTexture</span><span class="p">();</span></pre></td> <th \
bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">207</font></th> <td bgcolor="#ffffff" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; "> <span class="n">loadTexture</span><span \
class="p">();</span></pre></td> </tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">208</font></th> <td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: \
140%; margin: 0; "> <span class="k">if</span> <span class="p">(</span><span class="o"><span \
class="hl">!</span></span><span class="n">m_texture</span><span class="p">[</span><span \
class="mi">0</span><span class="p">])</span></pre></td> <th bgcolor="#e9eaa8" style="border-left: 1px \
solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">208</font></th> <td \
bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="k">if</span> <span class="p">(</span><span class="n">m_texture</span><span class="p">[</span><span \
class="mi">0</span><span class="p">]</span><span class="hl"> </span><span class="o"><span \
class="hl">==</span></span><span class="hl"> </span><span class="n"><span \
class="hl">nullptr</span></span><span class="p">)</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; \
white-space: -o-pre-wrap; word-wrap: break-word;">why this change? Please keep the logic and the ! \
instead of comparing to nullptr</pre> </div>
<br />
<p>- Martin</p>
<br />
<p>On August 26th, 2013, 6:06 p.m. CEST, Matteo De Carlo wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black solid;"> <tr>
<td>
<div>Review request for kwin and Martin Gräßlin.</div>
<div>By Matteo De Carlo.</div>
<p style="color: grey;"><i>Updated Aug. 26, 2013, 6:06 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid \
#b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Completing the task of replacing all NULL to \
nullptr in all the files in effects folder
task here: https://trello.com/c/z0a9UZdd/21-replace-null-with-nullptr</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kwin/effects/blur/blur_config.h <span style="color: grey">(bc33efc)</span></li>
<li>kwin/effects/blur/blurshader.cpp <span style="color: grey">(ad108f7)</span></li>
<li>kwin/effects/coverswitch/coverswitch.h <span style="color: grey">(75ebdfb)</span></li>
<li>kwin/effects/coverswitch/coverswitch.cpp <span style="color: grey">(6170a4a)</span></li>
<li>kwin/effects/coverswitch/coverswitch_config.h <span style="color: grey">(7945de2)</span></li>
<li>kwin/effects/cube/cube.cpp <span style="color: grey">(a4fc665)</span></li>
<li>kwin/effects/cube/cube_config.h <span style="color: grey">(378d7e1)</span></li>
<li>kwin/effects/cube/cubeslide_config.h <span style="color: grey">(fa7f18d)</span></li>
<li>kwin/effects/dashboard/dashboard.cpp <span style="color: grey">(e5bf396)</span></li>
<li>kwin/effects/dashboard/dashboard_config.h <span style="color: grey">(aaa09d6)</span></li>
<li>kwin/effects/desktopgrid/desktopgrid.h <span style="color: grey">(a9d5577)</span></li>
<li>kwin/effects/desktopgrid/desktopgrid.cpp <span style="color: grey">(f7f67f5)</span></li>
<li>kwin/effects/desktopgrid/desktopgrid_config.h <span style="color: grey">(8bd8727)</span></li>
<li>kwin/effects/diminactive/diminactive.cpp <span style="color: grey">(6a4a287)</span></li>
<li>kwin/effects/diminactive/diminactive_config.h <span style="color: grey">(c83b431)</span></li>
<li>kwin/effects/flipswitch/flipswitch.cpp <span style="color: grey">(9786ab5)</span></li>
<li>kwin/effects/flipswitch/flipswitch_config.h <span style="color: grey">(2c1e0fa)</span></li>
<li>kwin/effects/glide/glide_config.h <span style="color: grey">(e76e63a)</span></li>
<li>kwin/effects/highlightwindow/highlightwindow.cpp <span style="color: grey">(2452b07)</span></li>
<li>kwin/effects/invert/invert.cpp <span style="color: grey">(dd5d9ec)</span></li>
<li>kwin/effects/invert/invert_config.h <span style="color: grey">(1fab78c)</span></li>
<li>kwin/effects/logout/logout.cpp <span style="color: grey">(57e9519)</span></li>
<li>kwin/effects/lookingglass/lookingglass.cpp <span style="color: grey">(c5fc23a)</span></li>
<li>kwin/effects/lookingglass/lookingglass_config.h <span style="color: grey">(ef81612)</span></li>
<li>kwin/effects/magiclamp/magiclamp.cpp <span style="color: grey">(8595168)</span></li>
<li>kwin/effects/magiclamp/magiclamp_config.h <span style="color: grey">(4f07dd8)</span></li>
<li>kwin/effects/magnifier/magnifier.cpp <span style="color: grey">(01c8967)</span></li>
<li>kwin/effects/magnifier/magnifier_config.h <span style="color: grey">(f21652a)</span></li>
<li>kwin/effects/mouseclick/mouseclick.cpp <span style="color: grey">(c9c723e)</span></li>
<li>kwin/effects/mouseclick/mouseclick_config.h <span style="color: grey">(028662c)</span></li>
<li>kwin/effects/mousemark/mousemark.cpp <span style="color: grey">(5a86a16)</span></li>
<li>kwin/effects/mousemark/mousemark_config.h <span style="color: grey">(290c9ad)</span></li>
<li>kwin/effects/presentwindows/presentwindows.h <span style="color: grey">(32f0cf3)</span></li>
<li>kwin/effects/presentwindows/presentwindows.cpp <span style="color: grey">(37966d9)</span></li>
<li>kwin/effects/presentwindows/presentwindows_config.h <span style="color: grey">(5e5ca63)</span></li>
<li>kwin/effects/resize/resize.cpp <span style="color: grey">(a24e124)</span></li>
<li>kwin/effects/resize/resize_config.h <span style="color: grey">(f9742e0)</span></li>
<li>kwin/effects/screenedge/screenedgeeffect.cpp <span style="color: grey">(5e3c9e5)</span></li>
<li>kwin/effects/screenshot/screenshot.cpp <span style="color: grey">(1ea6cd0)</span></li>
<li>kwin/effects/showfps/showfps.cpp <span style="color: grey">(1ab7d57)</span></li>
<li>kwin/effects/showfps/showfps_config.h <span style="color: grey">(9858d5f)</span></li>
<li>kwin/effects/showpaint/showpaint.cpp <span style="color: grey">(9de4649)</span></li>
<li>kwin/effects/slide/slide.cpp <span style="color: grey">(7ed5408)</span></li>
<li>kwin/effects/slideback/slideback.cpp <span style="color: grey">(f280e03)</span></li>
<li>kwin/effects/snaphelper/snaphelper.cpp <span style="color: grey">(86dd4b6)</span></li>
<li>kwin/effects/taskbarthumbnail/taskbarthumbnail.cpp <span style="color: grey">(7319a93)</span></li>
<li>kwin/effects/thumbnailaside/thumbnailaside.cpp <span style="color: grey">(895f297)</span></li>
<li>kwin/effects/thumbnailaside/thumbnailaside_config.h <span style="color: grey">(6756672)</span></li>
<li>kwin/effects/trackmouse/trackmouse.cpp <span style="color: grey">(0b257ab)</span></li>
<li>kwin/effects/trackmouse/trackmouse_config.h <span style="color: grey">(211990d)</span></li>
<li>kwin/effects/windowgeometry/windowgeometry_config.h <span style="color: grey">(eaa49c4)</span></li>
<li>kwin/effects/wobblywindows/wobblywindows_config.h <span style="color: grey">(cb984c5)</span></li>
<li>kwin/effects/zoom/zoom.cpp <span style="color: grey">(1671343)</span></li>
<li>kwin/effects/zoom/zoom_config.h <span style="color: grey">(b59aa55)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/112298/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic