'Re: Review Request 112103: snap to deco, not client on inner screen borders'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Re: Review Request 112103: snap to deco, not client on inner screen borders
From:       Thomas_Lübking <thomas.luebking () gmail ! com>
Date:       2013-08-27 21:58:13
Message-ID: 20130827215813.8568.68597 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112103/
-----------------------------------------------------------

(Updated Aug. 27, 2013, 9:58 p.m.)

Review request for kwin and Martin Gräßlin.

Changes
-------

- prevent any screen bleeding, works with offset screens. window "jumps" from client \
                to deco when about to bleed.
- removed the part that snapped to client or deco on "outer" edges, depending on \
whether the snapping comes from in- or outside

Description
-------

inner borders are not infinite

This addresses bug 323504.
    http://bugs.kde.org/show_bug.cgi?id=323504

Diffs (updated)
-----

  kwin/geometry.cpp 480f97d 

Diff: http://git.reviewboard.kde.org/r/112103/diff/

Testing
-------

Thanks,

Thomas Lübking

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/112103/">http://git.reviewboard.kde.org/r/112103/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kwin and Martin Gräßlin.</div>
<div>By Thomas Lübking.</div>

<p style="color: grey;"><i>Updated Aug. 27, 2013, 9:58 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">- prevent any screen bleeding, works with offset screens. window \
                &quot;jumps&quot; from client to deco when about to bleed.
- removed the part that snapped to client or deco on &quot;outer&quot; edges, \
depending on whether the snapping comes from in- or outside</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">inner borders are not infinite</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=323504">323504</a>

</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>kwin/geometry.cpp <span style="color: grey">(480f97d)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/112103/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin

[prev in list] [next in list] [prev in thread] [next in thread] 