'Re: Review Request 112102: align zero corner placement to client, not deco'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Re: Review Request 112102: align zero corner placement to client, not deco
From:       Thomas_Lübking <thomas.luebking () gmail ! com>
Date:       2013-08-27 6:35:08
Message-ID: 20130827063508.20072.11942 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

> On Aug. 27, 2013, 6:07 a.m., Commit Hook wrote:
> > This review has been submitted with commit \
> > 6d256b2d149c68fd08888865b8a7fafdad397296 by Thomas Lübking to branch KDE/4.11.

Sorry, accidental commit.
It makes sense atm, but eventually needs to be reverted with the resolution of bug \
#323504, resp. review request #112103

- Thomas

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112102/#review38707
-----------------------------------------------------------

On Aug. 27, 2013, 6:07 a.m., Thomas Lübking wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112102/
> -----------------------------------------------------------
> 
> (Updated Aug. 27, 2013, 6:07 a.m.)
> 
> 
> Review request for kwin, Christoph Feck and Martin Gräßlin.
> 
> 
> Description
> -------
> 
> summarized, also see christophs argumentation on the bug
> 
> 
> This addresses bug 318107.
> http://bugs.kde.org/show_bug.cgi?id=318107
> 
> 
> Diffs
> -----
> 
> kwin/manage.cpp e4faec0 
> kwin/placement.cpp 55fcb34 
> 
> Diff: http://git.reviewboard.kde.org/r/112102/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Thomas Lübking
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/112102/">http://git.reviewboard.kde.org/r/112102/</a>
  </td>
    </tr>
   </table>
   <br />

<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <p style="margin-top: 0;">On August 27th, 2013, 6:07 a.m. UTC, <b>Commit \
Hook</b> wrote:</p>  <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">  <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This review has been submitted with commit \
6d256b2d149c68fd08888865b8a7fafdad397296 by Thomas Lübking to branch KDE/4.11.</pre> \
</blockquote>

</blockquote>

<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Sorry, accidental \
commit. It makes sense atm, but eventually needs to be reverted with the resolution \
of bug #323504, resp. review request #112103</pre> <br />

<p>- Thomas</p>

<br />
<p>On August 27th, 2013, 6:07 a.m. UTC, Thomas Lübking wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kwin, Christoph Feck and Martin Gräßlin.</div>
<div>By Thomas Lübking.</div>

<p style="color: grey;"><i>Updated Aug. 27, 2013, 6:07 a.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">summarized, also see christophs argumentation on the bug</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=318107">318107</a>

</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kwin/manage.cpp <span style="color: grey">(e4faec0)</span></li>

 <li>kwin/placement.cpp <span style="color: grey">(55fcb34)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/112102/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin

[prev in list] [next in list] [prev in thread] [next in thread] 