'Review Request 112196: KWin: Move the kwin4_effect_slide, kwin4_effect_fadedesktop and kwin4_effect_'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Review Request 112196: KWin: Move the kwin4_effect_slide, kwin4_effect_fadedesktop and kwin4_effect_
From:       "Antonis Tsiapaliokas" <kok3rs () gmail ! com>
Date:       2013-08-21 17:26:13
Message-ID: 20130821172613.18985.47144 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112196/
-----------------------------------------------------------

Review request for kwin and Martin Gräßlin.

Description
-------

On the new version of kcm_kwincompositing, we don't want those effects to be on a separate category becuase
the user will be able to enable only one of the above, using the UI of the new version of the kwincompositing.
So it is better to have all of the into one category in order to avoid any confusion to the user.

Diffs
-----

  kwin/effects/cube/cubeslide.desktop 082727d 
  kwin/effects/fadedesktop/package/metadata.desktop f929092 
  kwin/effects/slide/slide.desktop 8fe8495 

Diff: http://git.reviewboard.kde.org/r/112196/diff/

Testing
-------

Thanks,

Antonis Tsiapaliokas

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/112196/">http://git.reviewboard.kde.org/r/112196/</a>
     </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black solid;">  <tr>
  <td>

<div>Review request for kwin and Martin Gräßlin.</div>
<div>By Antonis Tsiapaliokas.</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid \
#b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">On the new version of kcm_kwincompositing, \
we don&#39;t want those effects to be on a separate category becuase the user will be able to enable only \
one of the above, using the UI of the new version of the kwincompositing. So it is better to have all of \
the into one category in order to avoid any confusion to the user.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kwin/effects/cube/cubeslide.desktop <span style="color: grey">(082727d)</span></li>

 <li>kwin/effects/fadedesktop/package/metadata.desktop <span style="color: grey">(f929092)</span></li>

 <li>kwin/effects/slide/slide.desktop <span style="color: grey">(8fe8495)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/112196/diff/" style="margin-left: 3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin

[prev in list] [next in list] [prev in thread] [next in thread] 