'Review Request 112133: reset custom cube shaders on screen change'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Review Request 112133: reset custom cube shaders on screen change
From:       Thomas_Lübking <thomas.luebking () gmail ! com>
Date:       2013-08-17 14:48:39
Message-ID: 20130817144839.27611.68150 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112133/
-----------------------------------------------------------

Review request for kwin and Martin Gräßlin.

Description
-------

the setup invokes the viewport dimensions.
This might affect more effects?

This addresses bug 323311.
    http://bugs.kde.org/show_bug.cgi?id=323311

Diffs
-----

  kwin/effects/cube/cube.h 4fb15ad 
  kwin/effects/cube/cube.cpp df01d7c 
  kwin/libkwineffects/kwinglutils.h 20a6601 
  kwin/libkwineffects/kwinglutils.cpp 777755a 

Diff: http://git.reviewboard.kde.org/r/112133/diff/

Testing
-------

Thanks,

Thomas Lübking

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/112133/">http://git.reviewboard.kde.org/r/112133/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kwin and Martin Gräßlin.</div>
<div>By Thomas Lübking.</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">the setup invokes the viewport dimensions. This might affect more \
effects?</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=323311">323311</a>

</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kwin/effects/cube/cube.h <span style="color: grey">(4fb15ad)</span></li>

 <li>kwin/effects/cube/cube.cpp <span style="color: grey">(df01d7c)</span></li>

 <li>kwin/libkwineffects/kwinglutils.h <span style="color: \
grey">(20a6601)</span></li>

 <li>kwin/libkwineffects/kwinglutils.cpp <span style="color: \
grey">(777755a)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/112133/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin

[prev in list] [next in list] [prev in thread] [next in thread] 