[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request 111898: KWin: Port effect away from KAction and KShortcut
From: "Commit Hook" <null () kde ! org>
Date: 2013-08-14 19:24:32
Message-ID: 20130814192432.16137.70817 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111898/
-----------------------------------------------------------
(Updated Aug. 14, 2013, 7:24 p.m.)
Status
------
This change has been marked as submitted.
Review request for kwin and Martin Gräßlin.
Description
-------
This diff replace KAction using QAction inside window geometry effect.
I rearranged #if KWIN_QT5_PORTING, to make the diff compileable.
Diffs
-----
kwin/effects/cube/cube.h 108bf1b
kwin/effects/cube/cube.cpp 057bb33
kwin/effects/cube/cube_config.cpp 6142a5e
kwin/effects/desktopgrid/desktopgrid.h c3fc462
kwin/effects/desktopgrid/desktopgrid.cpp 2fe3b6c
kwin/effects/desktopgrid/desktopgrid_config.cpp f95c944
kwin/effects/diminactive/diminactive_config.cpp adc6b6e
kwin/effects/flipswitch/flipswitch.h c238a93
kwin/effects/flipswitch/flipswitch.cpp aa96ff4
kwin/effects/flipswitch/flipswitch_config.cpp 1b7146f
kwin/effects/invert/invert.cpp 42a4fdb
kwin/effects/invert/invert_config.cpp 15d5f5c
kwin/effects/lookingglass/lookingglass.cpp bb4c9be
kwin/effects/lookingglass/lookingglass_config.cpp 0aadf09
kwin/effects/magnifier/magnifier.cpp 934242b
kwin/effects/magnifier/magnifier_config.cpp fc0ecfc
kwin/effects/mouseclick/mouseclick.cpp 71b5c69
kwin/effects/mouseclick/mouseclick_config.cpp 3749bcc
kwin/effects/mousemark/mousemark.cpp 619b983
kwin/effects/mousemark/mousemark_config.cpp 457fe52
kwin/effects/presentwindows/presentwindows.h 4d31944
kwin/effects/presentwindows/presentwindows.cpp fa21b36
kwin/effects/presentwindows/presentwindows_config.cpp 642281e
kwin/effects/thumbnailaside/thumbnailaside.cpp 672d34c
kwin/effects/thumbnailaside/thumbnailaside_config.cpp 5f6a64d
kwin/effects/trackmouse/trackmouse.h ad05af8
kwin/effects/trackmouse/trackmouse.cpp 39a0da5
kwin/effects/trackmouse/trackmouse_config.h d1850fe
kwin/effects/trackmouse/trackmouse_config.cpp 241d935
kwin/effects/windowgeometry/windowgeometry.cpp 3d0c978
kwin/effects/windowgeometry/windowgeometry_config.cpp 19b5505
kwin/effects/wobblywindows/wobblywindows_config.cpp 121b815
kwin/effects/zoom/zoom.cpp 236d4ab
kwin/effects/zoom/zoom_config.cpp c021fa2
Diff: http://git.reviewboard.kde.org/r/111898/diff/
Testing
-------
Thanks,
Reza Shah
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/111898/">http://git.reviewboard.kde.org/r/111898/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray \
solid;"> <tr>
<td>
<h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been \
marked as submitted.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin and Martin Gräßlin.</div>
<div>By Reza Shah.</div>
<p style="color: grey;"><i>Updated Aug. 14, 2013, 7:24 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This diff replace KAction using QAction inside window geometry effect. I \
rearranged #if KWIN_QT5_PORTING, to make the diff compileable.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kwin/effects/cube/cube.h <span style="color: grey">(108bf1b)</span></li>
<li>kwin/effects/cube/cube.cpp <span style="color: grey">(057bb33)</span></li>
<li>kwin/effects/cube/cube_config.cpp <span style="color: \
grey">(6142a5e)</span></li>
<li>kwin/effects/desktopgrid/desktopgrid.h <span style="color: \
grey">(c3fc462)</span></li>
<li>kwin/effects/desktopgrid/desktopgrid.cpp <span style="color: \
grey">(2fe3b6c)</span></li>
<li>kwin/effects/desktopgrid/desktopgrid_config.cpp <span style="color: \
grey">(f95c944)</span></li>
<li>kwin/effects/diminactive/diminactive_config.cpp <span style="color: \
grey">(adc6b6e)</span></li>
<li>kwin/effects/flipswitch/flipswitch.h <span style="color: \
grey">(c238a93)</span></li>
<li>kwin/effects/flipswitch/flipswitch.cpp <span style="color: \
grey">(aa96ff4)</span></li>
<li>kwin/effects/flipswitch/flipswitch_config.cpp <span style="color: \
grey">(1b7146f)</span></li>
<li>kwin/effects/invert/invert.cpp <span style="color: grey">(42a4fdb)</span></li>
<li>kwin/effects/invert/invert_config.cpp <span style="color: \
grey">(15d5f5c)</span></li>
<li>kwin/effects/lookingglass/lookingglass.cpp <span style="color: \
grey">(bb4c9be)</span></li>
<li>kwin/effects/lookingglass/lookingglass_config.cpp <span style="color: \
grey">(0aadf09)</span></li>
<li>kwin/effects/magnifier/magnifier.cpp <span style="color: \
grey">(934242b)</span></li>
<li>kwin/effects/magnifier/magnifier_config.cpp <span style="color: \
grey">(fc0ecfc)</span></li>
<li>kwin/effects/mouseclick/mouseclick.cpp <span style="color: \
grey">(71b5c69)</span></li>
<li>kwin/effects/mouseclick/mouseclick_config.cpp <span style="color: \
grey">(3749bcc)</span></li>
<li>kwin/effects/mousemark/mousemark.cpp <span style="color: \
grey">(619b983)</span></li>
<li>kwin/effects/mousemark/mousemark_config.cpp <span style="color: \
grey">(457fe52)</span></li>
<li>kwin/effects/presentwindows/presentwindows.h <span style="color: \
grey">(4d31944)</span></li>
<li>kwin/effects/presentwindows/presentwindows.cpp <span style="color: \
grey">(fa21b36)</span></li>
<li>kwin/effects/presentwindows/presentwindows_config.cpp <span style="color: \
grey">(642281e)</span></li>
<li>kwin/effects/thumbnailaside/thumbnailaside.cpp <span style="color: \
grey">(672d34c)</span></li>
<li>kwin/effects/thumbnailaside/thumbnailaside_config.cpp <span style="color: \
grey">(5f6a64d)</span></li>
<li>kwin/effects/trackmouse/trackmouse.h <span style="color: \
grey">(ad05af8)</span></li>
<li>kwin/effects/trackmouse/trackmouse.cpp <span style="color: \
grey">(39a0da5)</span></li>
<li>kwin/effects/trackmouse/trackmouse_config.h <span style="color: \
grey">(d1850fe)</span></li>
<li>kwin/effects/trackmouse/trackmouse_config.cpp <span style="color: \
grey">(241d935)</span></li>
<li>kwin/effects/windowgeometry/windowgeometry.cpp <span style="color: \
grey">(3d0c978)</span></li>
<li>kwin/effects/windowgeometry/windowgeometry_config.cpp <span style="color: \
grey">(19b5505)</span></li>
<li>kwin/effects/wobblywindows/wobblywindows_config.cpp <span style="color: \
grey">(121b815)</span></li>
<li>kwin/effects/zoom/zoom.cpp <span style="color: grey">(236d4ab)</span></li>
<li>kwin/effects/zoom/zoom_config.cpp <span style="color: \
grey">(c021fa2)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/111898/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic