'Re: Review Request 112020: make stacking_order exclusive during shutdown'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Re: Review Request 112020: make stacking_order exclusive during shutdown
From:       "Commit Hook" <null () kde ! org>
Date:       2013-08-13 19:56:09
Message-ID: 20130813195609.29749.74948 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112020/
-----------------------------------------------------------

(Updated Aug. 13, 2013, 7:56 p.m.)

Status
------

This change has been marked as submitted.

Review request for kwin and Martin Gräßlin.

Description
-------

Client::releaseClient() deletes all Client objects referenced by stacking_order, thus those pointers \
dangle and everything trying to touch it dies an ugly death.

There're basically two ways to deal with this:
* this ("copy" the list away and show everyone else an empty list)
* it = stacking_order.erase(it);

I prefer this solution since it allows to operate on const iterators and (more important, since copy \
overhead is nearly equal and irrelevant) providing a randomly partial stacking order on providing a \
stacking order is not gonna lead to the results you desire anyway.

Also the Unmanaged handling below has the same issue (deletes stuff referenced by the stacking order) so \
i guess the presented way is the correct option.

Nevertheless this needs testing against other (pot. more prominent) crashes on exit (anything expecting \
non-empty stacking orders or whatnot)

This addresses bug 323383.
    http://bugs.kde.org/show_bug.cgi?id=323383

Diffs
-----

  kwin/workspace.cpp 8237eed 

Diff: http://git.reviewboard.kde.org/r/112020/diff/

Testing
-------

kwin --replace still works

Thanks,

Thomas Lübking

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/112020/">http://git.reviewboard.kde.org/r/112020/</a>
     </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray solid;">
 <tr>
  <td>
   <h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black solid;">  <tr>
  <td>

<div>Review request for kwin and Martin Gräßlin.</div>
<div>By Thomas Lübking.</div>

<p style="color: grey;"><i>Updated Aug. 13, 2013, 7:56 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid \
#b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Client::releaseClient() deletes all Client \
objects referenced by stacking_order, thus those pointers dangle and everything trying to touch it dies \
an ugly death.

There&#39;re basically two ways to deal with this:
* this (&quot;copy&quot; the list away and show everyone else an empty list)
* it = stacking_order.erase(it);

I prefer this solution since it allows to operate on const iterators and (more important, since copy \
overhead is nearly equal and irrelevant) providing a randomly partial stacking order on providing a \
stacking order is not gonna lead to the results you desire anyway.

Also the Unmanaged handling below has the same issue (deletes stuff referenced by the stacking order) so \
i guess the presented way is the correct option.

Nevertheless this needs testing against other (pot. more prominent) crashes on exit (anything expecting \
non-empty stacking orders or whatnot)</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">kwin --replace still works</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=323383">323383</a>

</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kwin/workspace.cpp <span style="color: grey">(8237eed)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/112020/diff/" style="margin-left: 3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin

[prev in list] [next in list] [prev in thread] [next in thread] 