[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request 109783: split hasWaitSync to blocksForRetrace and syncsToVBlank
From: Martin_Gräßlin <mgraesslin () kde ! org>
Date: 2013-05-20 13:35:45
Message-ID: 20130520133545.20759.19385 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109783/#review32816
-----------------------------------------------------------
Ship it!
@Ralf: feel free to just check the "Ship It" box when you think something is ready to \
go.
- Martin Gräßlin
On May 15, 2013, 10:25 p.m., Thomas Lübking wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109783/
> -----------------------------------------------------------
>
> (Updated May 15, 2013, 10:25 p.m.)
>
>
> Review request for kwin, Martin Gräßlin and Ralf Jung.
>
>
> Description
> -------
>
> ... for that is not the same (though atm. syncsToVBlank is only used to determine \
> the fps interval - other usage pot. for supportInfo etc.)
> Also "hasWaitSync" is an implementation detail of GLX - EGL doesn't have it.
>
>
> Diffs
> -----
>
> kwin/composite.cpp 63b0735
> kwin/eglonxbackend.cpp 0d3ef17
> kwin/glxbackend.h 49b897e
> kwin/glxbackend.cpp cf28a9a
> kwin/scene.h 4dc4f47
> kwin/scene.cpp cb7d04b
> kwin/scene_opengl.h cb01664
> kwin/scene_opengl.cpp fc28035
>
> Diff: http://git.reviewboard.kde.org/r/109783/diff/
>
>
> Testing
> -------
>
> Compiles and runs. Is part of https://git.reviewboard.kde.org/r/109086/ and has \
> been used for pretty long here now.
>
> Thanks,
>
> Thomas Lübking
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/109783/">http://git.reviewboard.kde.org/r/109783/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">@Ralf: feel free to just \
check the "Ship It" box when you think something is ready to go.</pre> <br \
/>
<p>- Martin</p>
<br />
<p>On May 15th, 2013, 10:25 p.m. CEST, Thomas Lübking wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin, Martin Gräßlin and Ralf Jung.</div>
<div>By Thomas Lübking.</div>
<p style="color: grey;"><i>Updated May 15, 2013, 10:25 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">... for that is not the same (though atm. syncsToVBlank is only used to \
determine the fps interval - other usage pot. for supportInfo etc.)
Also "hasWaitSync" is an implementation detail of GLX - EGL doesn't \
have it.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Compiles and runs. Is part of https://git.reviewboard.kde.org/r/109086/ \
and has been used for pretty long here now.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kwin/composite.cpp <span style="color: grey">(63b0735)</span></li>
<li>kwin/eglonxbackend.cpp <span style="color: grey">(0d3ef17)</span></li>
<li>kwin/glxbackend.h <span style="color: grey">(49b897e)</span></li>
<li>kwin/glxbackend.cpp <span style="color: grey">(cf28a9a)</span></li>
<li>kwin/scene.h <span style="color: grey">(4dc4f47)</span></li>
<li>kwin/scene.cpp <span style="color: grey">(cb7d04b)</span></li>
<li>kwin/scene_opengl.h <span style="color: grey">(cb01664)</span></li>
<li>kwin/scene_opengl.cpp <span style="color: grey">(fc28035)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/109783/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic