[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    [RFC] Disable DrKonqi for KWin in stable releases
From:       Martin =?ISO-8859-1?Q?Gr=E4=DFlin?= <mgraesslin () kde ! org>
Date:       2013-04-30 11:37:51
Message-ID: 1532740.Bj5aqHZn4j () martin-desktop
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


Hi all,

<tldr>KWin gets too many crash reports, let's disable DrKonqi</tldr>

the latest post-Ubuntu-release crash report flood made me think that all the 
crashes we get are only causing work. There is no value in it except that we 
know that KWin once again crashed because Ubuntu is *insertrandominsulthere*. 
My initial idea was to discuss with Jonathan and Harald whether we could 
disable crash reporting just on Ubuntu.

But thinking more about it: there is no benefit at all in the crash reports 
reported against stable packages. It's all upstream or downstream issues. 
Since January 1st, 132 crash reports were created but only 10 of them have 
been fixed. Out of these 10 fixed reports only two are for 4.10.0 (with one of 
them from a Kubuntu dev running pre-alpha of raring) and one is for 4.10.1. 
All the other reports are for the alphas and betas.

My suggestion is therefore to push the following patch to stable branch and to 
future stable branches on final tagging day:
diff --git a/kwin/main.cpp b/kwin/main.cpp
index ed051f8..710c16d 100644
--- a/kwin/main.cpp
+++ b/kwin/main.cpp
@@ -273,6 +273,7 @@ Application::Application()
     connect(&owner, SIGNAL(lostOwnership()), SLOT(lostSelection()));
 
     KCrash::setEmergencySaveFunction(Application::crashHandler);
+    KCrash::setDrKonqiEnabled(false);
     crashes = args->getOption("crashes").toInt();
     if (crashes >= 4) {
         // Something has gone seriously wrong

We would still get the crash reports in master and during beta and RC for 
which we are interested, but all the junk would be disabled.

The nice side effect would be that it would look like improved quality as 
normaly a user wouldn't notice a KWin crash. It's a short flicker during which 
the window decorations got recrated, but that's it. Has there been a crash if 
nobody is there to notice it?

Opinions? Can somone convince me to not do it?

--
Martin Gräßlin
["signature.asc" (application/pgp-signature)]

_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin


[prev in list] [next in list] [prev in thread] [next in thread]