[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request 110232: delay withdraw of support properties
From: Thomas_Lübking <thomas.luebking () gmail ! com>
Date: 2013-04-29 21:16:11
Message-ID: 20130429211611.4052.82141 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On April 29, 2013, 8:04 p.m., Ralf Jung wrote:
> > Disabling compositing now has just one intermediate state ("black is the new \
> > transparent" ;-).
> > Enabling compositing sometimes has one intermediate state: Blurred background, \
> > but the foreground is brighter. It looks almost as if Plasma would use the \
> > non-blurred transparent theme. Is that possible?
It means there's a > 500ms delay between claiming the selection (after reading \
options, before actually creating the scene) and the blur effect setting the support \
property. Less than ideal - in effects/blur/blur.cpp, try moving the \
"net_wm_blur_region = \
effects->announceSupportProperty("_KDE_NET_WM_BLUR_BEHIND_REGION", this);" block on \
top of the constructor (notably before reading settings and creating the shader)
- Thomas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110232/#review31779
-----------------------------------------------------------
On April 29, 2013, 6:30 p.m., Thomas Lübking wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110232/
> -----------------------------------------------------------
>
> (Updated April 29, 2013, 6:30 p.m.)
>
>
> Review request for kwin, Martin Gräßlin and Ralf Jung.
>
>
> Description
> -------
>
> Fun fact: delaying the CM withdraw actually did (reg. plasma) not improve the \
> short-term (for reconfig) suspend and made things worse for the regular suspend.
> Background:
> plasma not only monitors the CM selector, but also some effect support properties \
> (blur)
> If either of that changes it alters the internal state and schedules rebuild of the \
> theme for 500ms, so what currently happens is
> 1. we remove the blur property
> 2. plasma alters from "translucent" to "normal" (unprefixed)
> 3. 500ms later plasma wipes the cache and repaints (rebuilding theme elements)
> In the regular suspend case
> 4. we wait 1500ms and remove the CM selector
> 5. plasma alters from "normal" (unprefixed) to "opaque"
> 6. 500ms later plasma wipes the cache and repaints (rebuilding theme elements)
>
> Therefore the patch keeps those properties for 2s, analogue to the CM selector.
> Since the effectshandler dies with compositing, this had to be moved up to the \
> Compositor::
> As result, plasma will not act in the reconfigure case and only once on real \
> suspend (since both events should fall into the same 500ms frame in this case)
>
> This addresses bugs (CC) and 179042.
> http://bugs.kde.org/show_bug.cgi?id=(CC)
> http://bugs.kde.org/show_bug.cgi?id=179042
>
>
> Diffs
> -----
>
> kwin/composite.h 2479eaa
> kwin/composite.cpp 223afc7
> kwin/effects.cpp 9d4b3db
>
> Diff: http://git.reviewboard.kde.org/r/110232/diff/
>
>
> Testing
> -------
>
> watched effect property presence
>
>
> Thanks,
>
> Thomas Lübking
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/110232/">http://git.reviewboard.kde.org/r/110232/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On April 29th, 2013, 8:04 p.m. UTC, <b>Ralf \
Jung</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Disabling compositing now has just one intermediate state ("black \
is the new transparent" ;-).
Enabling compositing sometimes has one intermediate state: Blurred background, but \
the foreground is brighter. It looks almost as if Plasma would use the non-blurred \
transparent theme. Is that possible?</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It means there's a \
> 500ms delay between claiming the selection (after reading options, before \
actually creating the scene) and the blur effect setting the support property. Less \
than ideal - in effects/blur/blur.cpp, try moving the "net_wm_blur_region = \
effects->announceSupportProperty("_KDE_NET_WM_BLUR_BEHIND_REGION", \
this);" block on top of the constructor (notably before reading settings and \
creating the shader)</pre> <br />
<p>- Thomas</p>
<br />
<p>On April 29th, 2013, 6:30 p.m. UTC, Thomas Lübking wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin, Martin Gräßlin and Ralf Jung.</div>
<div>By Thomas Lübking.</div>
<p style="color: grey;"><i>Updated April 29, 2013, 6:30 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Fun fact: delaying the CM withdraw actually did (reg. plasma) not \
improve the short-term (for reconfig) suspend and made things worse for the regular \
suspend.
Background:
plasma not only monitors the CM selector, but also some effect support properties \
(blur)
If either of that changes it alters the internal state and schedules rebuild of the \
theme for 500ms, so what currently happens is
1. we remove the blur property
2. plasma alters from "translucent" to "normal" (unprefixed)
3. 500ms later plasma wipes the cache and repaints (rebuilding theme elements)
In the regular suspend case
4. we wait 1500ms and remove the CM selector
5. plasma alters from "normal" (unprefixed) to "opaque"
6. 500ms later plasma wipes the cache and repaints (rebuilding theme elements)
Therefore the patch keeps those properties for 2s, analogue to the CM selector.
Since the effectshandler dies with compositing, this had to be moved up to the \
Compositor::
As result, plasma will not act in the reconfigure case and only once on real suspend \
(since both events should fall into the same 500ms frame in this case)</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">watched effect property presence</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=(CC)">(CC)</a>,
<a href="http://bugs.kde.org/show_bug.cgi?id=179042">179042</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kwin/composite.h <span style="color: grey">(2479eaa)</span></li>
<li>kwin/composite.cpp <span style="color: grey">(223afc7)</span></li>
<li>kwin/effects.cpp <span style="color: grey">(9d4b3db)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/110232/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic