[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request 110196: Remove unused typedefs in utils.h
From: Martin_Gräßlin <mgraesslin () kde ! org>
Date: 2013-04-29 7:49:59
Message-ID: 20130429074959.21132.75856 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On April 26, 2013, 3:16 p.m., Thomas Lübking wrote:
> > kwin/utils.h, line 80
> > <http://git.reviewboard.kde.org/r/110196/diff/1/?file=141088#file141088line80>
> >
> > This seems to be used only once (group.cpp) and there seems used as runner for a \
> > recursive test ::hasTransientInternal()
> > -> move into group.cpp?
> > (The other ones seem just added when other elements were added, mostly w/ \
> > compositing)
It's also used in client.h (definition of hasTransientInternal). So it would have to \
go into client.h and I think then it's better to leave it in utils.h together with \
the ClientList
- Martin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110196/#review31622
-----------------------------------------------------------
On April 26, 2013, 9:13 a.m., Martin Gräßlin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110196/
> -----------------------------------------------------------
>
> (Updated April 26, 2013, 9:13 a.m.)
>
>
> Review request for kwin.
>
>
> Description
> -------
>
> Remove unused typedefs in utils.h
>
> There is no Const(Toplevel|Unmanaged|Deleted|Group)List used anywhere.
> For ConstToplevelList there was a debug helper which was also unused.
>
>
> Diffs
> -----
>
> kwin/toplevel.h 5211e3819523cdb8b6089fbef3e1eae75daf9eff
> kwin/toplevel.cpp 611505b8507e9b86cdf25bb7ec700b3c9faf257e
> kwin/utils.h d24c425ce141429c13cc4b19679b3f9836033703
>
> Diff: http://git.reviewboard.kde.org/r/110196/diff/
>
>
> Testing
> -------
>
> compiles
>
>
> Thanks,
>
> Martin Gräßlin
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/110196/">http://git.reviewboard.kde.org/r/110196/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On April 26th, 2013, 3:16 p.m. CEST, <b>Thomas \
Lübking</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/110196/diff/1/?file=141088#file141088line80" \
style="color: black; font-weight: bold; text-decoration: underline;">kwin/utils.h</a> \
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
">typedef QList< Client* > ClientList;</pre></td> <td colspan="2"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; ">typedef QList< const \
Client* > ConstClientList;</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">80</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="k">typedef</span> \
<span class="n">QList</span><span class="o"><</span> <span class="k">const</span> \
<span class="n">Client</span><span class="o">*</span> <span class="o">></span> \
<span class="n">ConstClientList</span><span class="p">;</span></pre></td> <th \
bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">79</font></th> <td bgcolor="#ffffff" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="k">typedef</span> <span class="n">QList</span><span class="o"><</span> \
<span class="k">const</span> <span class="n">Client</span><span class="o">*</span> \
<span class="o">></span> <span class="n">ConstClientList</span><span \
class="p">;</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This seems to be used \
only once (group.cpp) and there seems used as runner for a recursive test \
::hasTransientInternal()
-> move into group.cpp?
(The other ones seem just added when other elements were added, mostly w/ \
compositing)</pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It's \
also used in client.h (definition of hasTransientInternal). So it would have to go \
into client.h and I think then it's better to leave it in utils.h together with \
the ClientList</pre> <br />
<p>- Martin</p>
<br />
<p>On April 26th, 2013, 9:13 a.m. CEST, Martin Gräßlin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin.</div>
<div>By Martin Gräßlin.</div>
<p style="color: grey;"><i>Updated April 26, 2013, 9:13 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Remove unused typedefs in utils.h
There is no Const(Toplevel|Unmanaged|Deleted|Group)List used anywhere.
For ConstToplevelList there was a debug helper which was also unused.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">compiles</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kwin/toplevel.h <span style="color: \
grey">(5211e3819523cdb8b6089fbef3e1eae75daf9eff)</span></li>
<li>kwin/toplevel.cpp <span style="color: \
grey">(611505b8507e9b86cdf25bb7ec700b3c9faf257e)</span></li>
<li>kwin/utils.h <span style="color: \
grey">(d24c425ce141429c13cc4b19679b3f9836033703)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/110196/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic