'Re: Review Request 110078: rules kcm, detection use X11 to grab the pointer'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Re: Review Request 110078: rules kcm, detection use X11 to grab the pointer
From:       "Commit Hook" <null () kde ! org>
Date:       2013-04-28 15:54:26
Message-ID: 20130428155426.3940.76539 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110078/
-----------------------------------------------------------

(Updated April 28, 2013, 3:54 p.m.)

Status
------

This change has been marked as submitted.

Review request for kwin and Martin Gräßlin.

Description
-------

Qt uses the appTime to grab the pointer what can (silently) fail:
"If the specified time is earlier than the last-pointer-grab time or later than the \
current X server time, it fails and returns GrabInvalidTime."

Therefore we grab ourself, convince X11 by CurrentTime and then have Qt grab the \
pointer (so it will expose this condition and also do regular ungrab stuff, while \
deleted and unmapped, the grabber dialog can't hold a grab anymore anyway) only in \
the success case - otherwise (like a popup currently actually grabs the pointer) \
clean up and esp. not intercept "in-house" clicks, leading to confusive \
self-detection on "cancel" approaches.

This addresses bug 318437.
    http://bugs.kde.org/show_bug.cgi?id=318437

Diffs
-----

  kwin/kcmkwin/kwinrules/detectwidget.cpp 06be198 

Diff: http://git.reviewboard.kde.org/r/110078/diff/

Testing
-------

Yupp.

Thanks,

Thomas Lübking

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/110078/">http://git.reviewboard.kde.org/r/110078/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray \
solid;">  <tr>
  <td>
   <h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been \
marked as submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kwin and Martin Gräßlin.</div>
<div>By Thomas Lübking.</div>

<p style="color: grey;"><i>Updated April 28, 2013, 3:54 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Qt uses the appTime to grab the pointer what can (silently) fail: \
&quot;If the specified time is earlier than the last-pointer-grab time or later than \
the current X server time, it fails and returns GrabInvalidTime.&quot;

Therefore we grab ourself, convince X11 by CurrentTime and then have Qt grab the \
pointer (so it will expose this condition and also do regular ungrab stuff, while \
deleted and unmapped, the grabber dialog can&#39;t hold a grab anymore anyway) only \
in the success case - otherwise (like a popup currently actually grabs the pointer) \
clean up and esp. not intercept &quot;in-house&quot; clicks, leading to confusive \
self-detection on &quot;cancel&quot; approaches.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Yupp.</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=318437">318437</a>

</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kwin/kcmkwin/kwinrules/detectwidget.cpp <span style="color: \
grey">(06be198)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/110078/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin

[prev in list] [next in list] [prev in thread] [next in thread] 