'Re: Review Request 107603: some stashed changes I want to share'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Re: Review Request 107603: some stashed changes I want to share
From:       "Jaime Torres Amate" <jtamate () gmail ! com>
Date:       2013-04-28 9:36:21
Message-ID: 20130428093621.21668.56341 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107603/
-----------------------------------------------------------

(Updated April 28, 2013, 9:36 a.m.)

Review request for kwin.

Changes
-------

Updated the patch to discard the wrong parts and reflect the reviews indications.

Description (updated)
-------

* Initialize a member pointer
* place the parenthesis in the right position to check if floats.count()<2 after assigning the \
result to forced_align

Diffs (updated)
-----

  kwin/kcmkwin/kwindesktop/desktopnameswidget.cpp 81b14ad 
  kwin/libkwineffects/anidata.cpp 09635b0 

Diff: http://git.reviewboard.kde.org/r/107603/diff/

Testing (updated)
-------

I've been using the changed kwin almost two months.

Thanks,

Jaime Torres Amate

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/107603/">http://git.reviewboard.kde.org/r/107603/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black solid;">  <tr>
  <td>

<div>Review request for kwin.</div>
<div>By Jaime Torres Amate.</div>

<p style="color: grey;"><i>Updated April 28, 2013, 9:36 a.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid \
#b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Updated the patch to \
discard the wrong parts and reflect the reviews indications.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description  (updated)</h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px \
solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">* Initialize a member \
                pointer
* place the parenthesis in the right position to check if floats.count()&lt;2 after assigning \
the result to forced_align</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing (updated)</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid \
#b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I&#39;ve been using \
the changed kwin almost two months.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kwin/kcmkwin/kwindesktop/desktopnameswidget.cpp <span style="color: \
grey">(81b14ad)</span></li>

 <li>kwin/libkwineffects/anidata.cpp <span style="color: grey">(09635b0)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/107603/diff/" style="margin-left: 3em;">View \
Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin

[prev in list] [next in list] [prev in thread] [next in thread] 