[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request 110176: Change the visual appearance of the composited outline
From: Thomas_Lübking <thomas.luebking () gmail ! com>
Date: 2013-04-25 12:28:59
Message-ID: 20130425122859.21722.14144 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110176/#review31550
-----------------------------------------------------------
It's a definitively visual improvement with many themes (including and esp. air), but \
eg. (old) oxygen and several others still get me a black overlay that does not much \
look like a frame or window and with "opaquity" it's (surprise) *opaque* (ie. one \
side of the screen turns -near- black)
http://techbase.kde.org/Development/Tutorials/Plasma/ThemeDetails
/translucentbackground.svg: a standard background image for plasmoids that for their \
nature are bigger and with not much text. In this case a translucent background looks \
better. It needs the same elements of background.svg in it. If this file is not \
present, the plasmoids that uses this will use background.svg instead.
There's (unfortunately) no explicit requirement on that either this is translucent or \
exists at all (what will get us the regular "solid" background)
For the beginning, i'd strongly recommend to elevate the to-be-tiled window over the \
"outline".
- Thomas Lübking
On April 25, 2013, 8:58 a.m., Martin Gräßlin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110176/
> -----------------------------------------------------------
>
> (Updated April 25, 2013, 8:58 a.m.)
>
>
> Review request for kwin and Plasma.
>
>
> Description
> -------
>
> Change the visual appearance of the composited outline
>
> Uses widgets/translucentbackground as FrameSvg item to ensure that we
> don't get a huge black square on the screen.
>
> When bordering a screen edge we disable the border except if all edges
> are bordered. This makes a little bit more clear in the quick tiling case
> what will be the geometry.
>
> Blur behind the outline does not work as:
> * moving the window generates artefacts
> * moved window needs to be above the outline, but outline needs to be on
> top of everything. Elevating the moved window results in strange
> side effects when moving the window "below" a keep above, etc.
>
>
> Diffs
> -----
>
> kwin/outline.cpp ad3cfc01f6fa29010de6845d6c17a54e59d9474e
>
> Diff: http://git.reviewboard.kde.org/r/110176/diff/
>
>
> Testing
> -------
>
> I tried various Plasma theme elements. dialog/* and widgets/background are not \
> useable as there are solid themes.
>
> Thanks,
>
> Martin Gräßlin
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/110176/">http://git.reviewboard.kde.org/r/110176/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It's a definitively \
visual improvement with many themes (including and esp. air), but eg. (old) oxygen \
and several others still get me a black overlay that does not much look like a frame \
or window and with "opaquity" it's (surprise) *opaque* (ie. one side of \
the screen turns -near- black)
http://techbase.kde.org/Development/Tutorials/Plasma/ThemeDetails
/translucentbackground.svg: a standard background image for plasmoids that for their \
nature are bigger and with not much text. In this case a translucent background looks \
better. It needs the same elements of background.svg in it. If this file is not \
present, the plasmoids that uses this will use background.svg instead.
There's (unfortunately) no explicit requirement on that either this is \
translucent or exists at all (what will get us the regular "solid" \
background)
For the beginning, i'd strongly recommend to elevate the to-be-tiled window over \
the "outline".</pre> <br />
<p>- Thomas</p>
<br />
<p>On April 25th, 2013, 8:58 a.m. UTC, Martin Gräßlin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin and Plasma.</div>
<div>By Martin Gräßlin.</div>
<p style="color: grey;"><i>Updated April 25, 2013, 8:58 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Change the visual appearance of the composited outline
Uses widgets/translucentbackground as FrameSvg item to ensure that we
don't get a huge black square on the screen.
When bordering a screen edge we disable the border except if all edges
are bordered. This makes a little bit more clear in the quick tiling case
what will be the geometry.
Blur behind the outline does not work as:
* moving the window generates artefacts
* moved window needs to be above the outline, but outline needs to be on
top of everything. Elevating the moved window results in strange
side effects when moving the window "below" a keep above, etc.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I tried various Plasma theme elements. dialog/* and widgets/background \
are not useable as there are solid themes.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kwin/outline.cpp <span style="color: \
grey">(ad3cfc01f6fa29010de6845d6c17a54e59d9474e)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/110176/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic