[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request 109784: rebase measuring to nano resolution and fix initial padding
From: Thomas_Lübking <thomas.luebking () gmail ! com>
Date: 2013-04-10 17:58:48
Message-ID: 20130410175848.7757.30553 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On April 2, 2013, 11:10 a.m., Ralf Jung wrote:
> > kwin/composite.cpp, line 66
> > <http://git.reviewboard.kde.org/r/109784/diff/2/?file=126721#file126721line66>
> >
> > Shouldn't this say "milli", as in "milliseconds"?
There goes symmetry :-(
- Thomas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109784/#review30258
-----------------------------------------------------------
On March 30, 2013, 5:40 p.m., Thomas Lübking wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109784/
> -----------------------------------------------------------
>
> (Updated March 30, 2013, 5:40 p.m.)
>
>
> Review request for kwin, Martin Gräßlin and Ralf Jung.
>
>
> Description
> -------
>
> summarized
>
>
> Diffs
> -----
>
> kwin/composite.h ebaf7e7
> kwin/composite.cpp ee885dc
> kwin/options.h f61a66f
> kwin/options.cpp 6abd3f0
> kwin/scene.h 5d49c40
> kwin/scene_opengl.h 409ec3d
> kwin/scene_opengl.cpp 3343164
> kwin/scene_xrender.h 4a93940
> kwin/scene_xrender.cpp ab90815
>
> Diff: http://git.reviewboard.kde.org/r/109784/diff/
>
>
> Testing
> -------
>
> it's math.
> fpsinterval is n*vblankTime so this moves it 1ms past the last assumed tick before \
> the wanted interval spot, so that we don't have to fear to miss it.
> Assuming we paint every 3rd frame:
>
> A 1 2 3 4 5 - B 1 2 3 4 5 - C 1 2 3 4 5 - A
> ^ here (C1)
>
>
> Thanks,
>
> Thomas Lübking
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/109784/">http://git.reviewboard.kde.org/r/109784/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On April 2nd, 2013, 11:10 a.m. UTC, <b>Ralf \
Jung</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/109784/diff/2/?file=126721#file126721line66" \
style="color: black; font-weight: bold; text-decoration: \
underline;">kwin/composite.cpp</a> <span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
">Q_DECLARE_METATYPE(KWin::Compositor::SuspendReason)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">66</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="k">static</span> <span class="kr">inline</span> <span class="n">qint64</span> \
<span class="nf">miliToNano</span><span class="p">(</span><span class="kt">int</span> \
<span class="n">mili</span><span class="p">)</span> <span class="p">{</span> <span \
class="k">return</span> <span class="n">mili</span> <span class="o">*</span> <span \
class="mi">1000</span> <span class="o">*</span> <span class="mi">1000</span><span \
class="p">;</span> <span class="p">}</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Shouldn't this say \
"milli", as in "milliseconds"?</pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">There goes \
symmetry :-(</pre> <br />
<p>- Thomas</p>
<br />
<p>On March 30th, 2013, 5:40 p.m. UTC, Thomas Lübking wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin, Martin Gräßlin and Ralf Jung.</div>
<div>By Thomas Lübking.</div>
<p style="color: grey;"><i>Updated March 30, 2013, 5:40 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">summarized</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">it's math. fpsinterval is n*vblankTime so this moves it 1ms past the \
last assumed tick before the wanted interval spot, so that we don't have to fear \
to miss it.
Assuming we paint every 3rd frame:
A 1 2 3 4 5 - B 1 2 3 4 5 - C 1 2 3 4 5 - A
^ here (C1)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kwin/composite.h <span style="color: grey">(ebaf7e7)</span></li>
<li>kwin/composite.cpp <span style="color: grey">(ee885dc)</span></li>
<li>kwin/options.h <span style="color: grey">(f61a66f)</span></li>
<li>kwin/options.cpp <span style="color: grey">(6abd3f0)</span></li>
<li>kwin/scene.h <span style="color: grey">(5d49c40)</span></li>
<li>kwin/scene_opengl.h <span style="color: grey">(409ec3d)</span></li>
<li>kwin/scene_opengl.cpp <span style="color: grey">(3343164)</span></li>
<li>kwin/scene_xrender.h <span style="color: grey">(4a93940)</span></li>
<li>kwin/scene_xrender.cpp <span style="color: grey">(ab90815)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/109784/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic