[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request 106110: Make autohide panel do not intercept events in fullscreen app
From: "Aaron J. Seigo" <aseigo () kde ! org>
Date: 2013-04-08 14:04:38
Message-ID: 20130408140438.16260.80212 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On March 20, 2013, 2 p.m., Aaron J. Seigo wrote:
> > plasma/desktop/shell/panelview.cpp, line 1496
> > <http://git.reviewboard.kde.org/r/106110/diff/5/?file=120303#file120303line1496>
> >
> > Better would simply be to compare screens. If they are on the same screen -> \
> > don't interfere.
>
> Thomas Lübking wrote:
> a fullscreen window can cover more than one screen (@Martin: there's even a netwm \
> hint on that for xinerama ;-) What you wanted to check is whether the panel and the \
> window intersect.
which would require calculating the geometry when the panel is unhidden. it is easier \
to ask "is this window full screen and does it show on the same screen as this \
panel". it has nothing to do with "does a window only cover one screen" and can be \
done sth like: activeWindow.geometry().intersects(QApplication::desktop()->screenGeometry(screen()));
- Aaron J.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106110/#review29551
-----------------------------------------------------------
On March 22, 2013, 4:53 p.m., Alexey Shmalko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106110/
> -----------------------------------------------------------
>
> (Updated March 22, 2013, 4:53 p.m.)
>
>
> Review request for kwin and Plasma.
>
>
> Description
> -------
>
> Make autohide panel do not intercept events in fullscreen app.
>
> I changed PanelView::createUnhideTrigger() to check whether current active \
> application is in fullscreen mode. So in fullscreen applications panel will be \
> always hidden.
>
> This addresses bug 217560.
> http://bugs.kde.org/show_bug.cgi?id=217560
>
>
> Diffs
> -----
>
> plasma/desktop/shell/panelview.cpp 7713740
>
> Diff: http://git.reviewboard.kde.org/r/106110/diff/
>
>
> Testing
> -------
>
> Tested with patched gentoo ebuild. Works fine.
>
>
> Thanks,
>
> Alexey Shmalko
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106110/">http://git.reviewboard.kde.org/r/106110/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On March 20th, 2013, 2 p.m. UTC, <b>Aaron J. \
Seigo</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/106110/diff/5/?file=120303#file120303line1496" \
style="color: black; font-weight: bold; text-decoration: \
underline;">plasma/desktop/shell/panelview.cpp</a> <span style="font-weight: \
normal;">
(Diff revision 5)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
PanelView::createUnhideTrigger()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">1496</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">fancy</span> <span class="o">=</span> <span \
class="n">activeWindow</span><span class="p">.</span><span \
class="n">hasState</span><span class="p">(</span><span class="n">NET</span><span \
class="o">::</span><span class="n">FullScreen</span><span class="p">)</span> <span \
class="o">&&</span> <span class="n">geometry</span><span \
class="p">().</span><span class="n">contains</span><span class="p">(</span><span \
class="n">activeWindow</span><span class="p">.</span><span \
class="n">geometry</span><span class="p">());</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Better would simply be \
to compare screens. If they are on the same screen -> don't interfere.</pre> \
</blockquote>
<p>On March 21st, 2013, 6:51 p.m. UTC, <b>Thomas Lübking</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">a fullscreen window can \
cover more than one screen (@Martin: there's even a netwm hint on that for \
xinerama ;-) What you wanted to check is whether the panel and the window \
intersect.</pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">which would \
require calculating the geometry when the panel is unhidden. it is easier to ask \
"is this window full screen and does it show on the same screen as this \
panel". it has nothing to do with "does a window only cover one \
screen" and can be done sth like: \
activeWindow.geometry().intersects(QApplication::desktop()->screenGeometry(screen()));</pre>
<br />
<p>- Aaron J.</p>
<br />
<p>On March 22nd, 2013, 4:53 p.m. UTC, Alexey Shmalko wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin and Plasma.</div>
<div>By Alexey Shmalko.</div>
<p style="color: grey;"><i>Updated March 22, 2013, 4:53 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Make autohide panel do not intercept events in fullscreen app.
I changed PanelView::createUnhideTrigger() to check whether current active \
application is in fullscreen mode. So in fullscreen applications panel will be always \
hidden.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested with patched gentoo ebuild. Works fine.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=217560">217560</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/desktop/shell/panelview.cpp <span style="color: \
grey">(7713740)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106110/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic