[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request 109795: Don't redirect/unredirect windows too frequent
From: "Alexander Mezin" <mezin.alexander () gmail ! com>
Date: 2013-04-02 1:05:03
Message-ID: 20130402010503.22574.3729 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On April 1, 2013, 9:08 a.m., Martin Gräßlin wrote:
> > After thinking over it, I came to the conclusion that it makes sense to include \
> > this change. Codingwise it looks good to me, but maybe Thomas has another comment \
> > on it ;-)
> > Do you have commit rights? If not please just upload a diff which has been \
> > exported with git format-patch and I'll push it.
>
> Alexander Mezin wrote:
> No, I don't have commit rights. The patch is already done with git format-patch.
>
> Alexander Mezin wrote:
> Recently discovered that this patch also fixes xonotic-glx
>
> Thomas Lübking wrote:
> No further comments.
> The RB diff seems to now include the fully formatted git patch (@Alexander: it used \
> to scratch this meta information)
> By "also fixes xonotic-glx" you refer to the same condition as with meat boy?
Sorry, made a mistake. Yesterday xonotic-glx crashed with non-patched kwin-4.10.1, \
but now I can't make it crash again (with or without this patch).
- Alexander
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109795/#review30197
-----------------------------------------------------------
On March 30, 2013, 3:16 p.m., Alexander Mezin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109795/
> -----------------------------------------------------------
>
> (Updated March 30, 2013, 3:16 p.m.)
>
>
> Review request for kwin.
>
>
> Description
> -------
>
> Super Meat Boy freezes when I start it full-screen with OpenGL compositing engine.
>
> The game causes frequent unredirections/redirections during startup, and seems that \
> they can't be handled properly. To workaround this, delay subsequent redirections. \
> First unredirection is done without delay as it was before.
>
> Diffs
> -----
>
> kwin/composite.cpp ee885dc
>
> Diff: http://git.reviewboard.kde.org/r/109795/diff/
>
>
> Testing
> -------
>
> Tested on KDE 4.10.1
> Xonotic, Super Meat Boy, Battle for Wesnoth runs fine.
>
>
> Thanks,
>
> Alexander Mezin
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/109795/">http://git.reviewboard.kde.org/r/109795/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On April 1st, 2013, 9:08 a.m. UTC, <b>Martin \
Gräßlin</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">After thinking over it, I came to the conclusion that it makes sense to \
include this change. Codingwise it looks good to me, but maybe Thomas has another \
comment on it ;-)
Do you have commit rights? If not please just upload a diff which has been exported \
with git format-patch and I'll push it.</pre> </blockquote>
<p>On April 1st, 2013, 9:15 a.m. UTC, <b>Alexander Mezin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">No, I don't have \
commit rights. The patch is already done with git format-patch.</pre> </blockquote>
<p>On April 1st, 2013, 11:10 a.m. UTC, <b>Alexander Mezin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Recently discovered that \
this patch also fixes xonotic-glx</pre> </blockquote>
<p>On April 1st, 2013, 1:40 p.m. UTC, <b>Thomas Lübking</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">No further comments. The \
RB diff seems to now include the fully formatted git patch (@Alexander: it used to \
scratch this meta information)
By "also fixes xonotic-glx" you refer to the same condition as with meat \
boy?</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Sorry, made a mistake. \
Yesterday xonotic-glx crashed with non-patched kwin-4.10.1, but now I can't make \
it crash again (with or without this patch).</pre> <br />
<p>- Alexander</p>
<br />
<p>On March 30th, 2013, 3:16 p.m. UTC, Alexander Mezin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin.</div>
<div>By Alexander Mezin.</div>
<p style="color: grey;"><i>Updated March 30, 2013, 3:16 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Super Meat Boy freezes when I start it full-screen with OpenGL \
compositing engine.
The game causes frequent unredirections/redirections during startup, and seems that \
they can't be handled properly. To workaround this, delay subsequent \
redirections. First unredirection is done without delay as it was before.</pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested on KDE 4.10.1 Xonotic, Super Meat Boy, Battle for Wesnoth runs \
fine.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kwin/composite.cpp <span style="color: grey">(ee885dc)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/109795/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic