[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request 109795: Don't redirect/unredirect windows too frequent
From: Thomas_Lübking <thomas.luebking () gmail ! com>
Date: 2013-03-30 13:40:55
Message-ID: 20130330134055.32515.89379 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On March 30, 2013, 9:16 a.m., Martin Gräßlin wrote:
> > I must admit that I'm sceptical about adding the check - need to think about it. \
> > In general I think bugs caused by one specific client should be fixed in the \
> > client and not worked around in the window manager. On the other hand it might be \
> > reasonable to add this delay. But it's a no-go for the 4.10 branch - I consider \
> > this as a feature.
>
> Alexander Mezin wrote:
> I think that there could be other broken clients. Reminds me of Windows games which \
> crash on alt-tab. Also, it's a client that unlikely will be fixed. Last update \
> happened more than year ago, and there's still many unresolved bugs.
regardless of the outcome of a particular client that i could not care less about, \
KWin decides about the unredirection state into which unspecified criteria a client \
can legally drop in and out about any time - it's reasonable to avoid unnecessary \
costs caused by this.
Whether and how much that can be a real-life issue, i can't say.
- Thomas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109795/#review30096
-----------------------------------------------------------
On March 30, 2013, 9:41 a.m., Alexander Mezin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109795/
> -----------------------------------------------------------
>
> (Updated March 30, 2013, 9:41 a.m.)
>
>
> Review request for kwin.
>
>
> Description
> -------
>
> Super Meat Boy freezes when I start it full-screen with OpenGL compositing engine.
>
> The game causes frequent unredirections/redirections during startup, and seems that \
> they can't be handled properly. To workaround this, delay subsequent redirections. \
> First unredirection is done without delay as it was before.
>
> Diffs
> -----
>
> kwin/composite.h ebaf7e7
> kwin/composite.cpp ee885dc
> kwin/toplevel.h 0cd8d0a
> kwin/toplevel.cpp 1d4406c
>
> Diff: http://git.reviewboard.kde.org/r/109795/diff/
>
>
> Testing
> -------
>
> Tested on KDE 4.10.1
> Xonotic, Super Meat Boy, Battle for Wesnoth runs fine.
>
>
> Thanks,
>
> Alexander Mezin
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/109795/">http://git.reviewboard.kde.org/r/109795/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On March 30th, 2013, 9:16 a.m. UTC, <b>Martin \
Gräßlin</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I must admit that I'm sceptical about adding the check - need to \
think about it. In general I think bugs caused by one specific client should be fixed \
in the client and not worked around in the window manager. On the other hand it might \
be reasonable to add this delay. But it's a no-go for the 4.10 branch - I \
consider this as a feature.</pre> </blockquote>
<p>On March 30th, 2013, 9:41 a.m. UTC, <b>Alexander Mezin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I think that there could \
be other broken clients. Reminds me of Windows games which crash on alt-tab. Also, \
it's a client that unlikely will be fixed. Last update happened more than year \
ago, and there's still many unresolved bugs.</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">regardless of the \
outcome of a particular client that i could not care less about, KWin decides about \
the unredirection state into which unspecified criteria a client can legally drop in \
and out about any time - it's reasonable to avoid unnecessary costs caused by \
this.
Whether and how much that can be a real-life issue, i can't say.</pre>
<br />
<p>- Thomas</p>
<br />
<p>On March 30th, 2013, 9:41 a.m. UTC, Alexander Mezin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin.</div>
<div>By Alexander Mezin.</div>
<p style="color: grey;"><i>Updated March 30, 2013, 9:41 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Super Meat Boy freezes when I start it full-screen with OpenGL \
compositing engine.
The game causes frequent unredirections/redirections during startup, and seems that \
they can't be handled properly. To workaround this, delay subsequent \
redirections. First unredirection is done without delay as it was before.</pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested on KDE 4.10.1 Xonotic, Super Meat Boy, Battle for Wesnoth runs \
fine.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kwin/composite.h <span style="color: grey">(ebaf7e7)</span></li>
<li>kwin/composite.cpp <span style="color: grey">(ee885dc)</span></li>
<li>kwin/toplevel.h <span style="color: grey">(0cd8d0a)</span></li>
<li>kwin/toplevel.cpp <span style="color: grey">(1d4406c)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/109795/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic