From kwin Sat Mar 30 09:06:30 2013 From: =?utf-8?q?Martin_Gr=C3=A4=C3=9Flin?= Date: Sat, 30 Mar 2013 09:06:30 +0000 To: kwin Subject: Re: Review Request 109075: Rewrite of Scale In effect to JavaScript Message-Id: <20130330090630.22348.99490 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kwin&m=136463440615283 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============3490626586819219427==" --===============3490626586819219427== Content-Type: multipart/alternative; boundary="===============7589309899407519115==" --===============7589309899407519115== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109075/#review30095 ----------------------------------------------------------- Ship it! Ship It! - Martin Gräßlin On March 29, 2013, 7:35 p.m., Kai Uwe Broulik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/109075/ > ----------------------------------------------------------- > > (Updated March 29, 2013, 7:35 p.m.) > > > Review request for kwin. > > > Description > ------- > > This patch re-implements the Scale In effect in JavaScript. > > We probably need some sort of update script? Since the current effect is just scalein.desktop while this one is now kwin4_effect_scalein.desktop > > > Diffs > ----- > > kwin/effects/CMakeLists.txt 6d2457c > kwin/effects/scalein/CMakeLists.txt 6a16861 > kwin/effects/scalein/package/CMakeLists.txt PRE-CREATION > kwin/effects/scalein/package/contents/code/main.js PRE-CREATION > kwin/effects/scalein/package/metadata.desktop PRE-CREATION > kwin/effects/scalein/scalein.cpp e78b0b2 > kwin/effects/scalein/scalein.desktop a084435 > kwin/effects/scalein/scalein.h 0b3ae56 > > Diff: http://git.reviewboard.kde.org/r/109075/diff/ > > > Testing > ------- > > On OpenGL it works as expected (windows zoom in, but for instance Plasma popups don't) but on my lightdm --test-mode session which only supports XRender, also the Plasma popups zoom in. Couldn't figure out why that is. > > > Thanks, > > Kai Uwe Broulik > > --===============7589309899407519115== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit
This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109075/

Ship it!

Ship It!

- Martin


On March 29th, 2013, 7:35 p.m. CET, Kai Uwe Broulik wrote:

Review request for kwin.
By Kai Uwe Broulik.

Updated March 29, 2013, 7:35 p.m.

Description 

This patch re-implements the Scale In effect in JavaScript.

We probably need some sort of update script? Since the current effect is just scalein.desktop while this one is now kwin4_effect_scalein.desktop

Testing 

On OpenGL it works as expected (windows zoom in, but for instance Plasma popups don't) but on my lightdm --test-mode session which only supports XRender, also the Plasma popups zoom in. Couldn't figure out why that is.

Diffs

  • kwin/effects/CMakeLists.txt (6d2457c)
  • kwin/effects/scalein/CMakeLists.txt (6a16861)
  • kwin/effects/scalein/package/CMakeLists.txt (PRE-CREATION)
  • kwin/effects/scalein/package/contents/code/main.js (PRE-CREATION)
  • kwin/effects/scalein/package/metadata.desktop (PRE-CREATION)
  • kwin/effects/scalein/scalein.cpp (e78b0b2)
  • kwin/effects/scalein/scalein.desktop (a084435)
  • kwin/effects/scalein/scalein.h (0b3ae56)

View Diff
--===============7589309899407519115==-- --===============3490626586819219427== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ kwin mailing list kwin@kde.org https://mail.kde.org/mailman/listinfo/kwin --===============3490626586819219427==--