'Review Request 109795:'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Review Request 109795:
From:       "Alexander Mezin" <mezin.alexander () gmail ! com>
Date:       2013-03-29 17:10:01
Message-ID: 20130329171001.1711.16391 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109795/
-----------------------------------------------------------

Review request for kwin.

Description
-------

Super Meat Boy freezes when I start it full-screen with OpenGL compositing engine. \
Seems that kwin just does its work unexpectedly fast.  
Actually, even 1 ms delay or removing "if" fixes the problem for me.

But to be sure I think it's better to:
1) increase delay up to 100 ms. I think it can't be noticed by user
2) remove the "if", so successive calls won't be handled faster if the timer wasn't \
timed out before these calls was made.

Could this patch cause any problems?

Diffs
-----

  kwin/composite.cpp ee885dc 

Diff: http://git.reviewboard.kde.org/r/109795/diff/

Testing
-------

Tested on KDE 4.10.1
Xonotic, Super Meat Boy, Battle for Wesnoth runs fine.

Thanks,

Alexander Mezin

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/109795/">http://git.reviewboard.kde.org/r/109795/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kwin.</div>
<div>By Alexander Mezin.</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Super Meat Boy freezes when I start it full-screen with OpenGL \
compositing engine. Seems that kwin just does its work unexpectedly fast.  
Actually, even 1 ms delay or removing &quot;if&quot; fixes the problem for me.

But to be sure I think it&#39;s better to:
1) increase delay up to 100 ms. I think it can&#39;t be noticed by user
2) remove the &quot;if&quot;, so successive calls won&#39;t be handled faster if the \
timer wasn&#39;t timed out before these calls was made.

Could this patch cause any problems?</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested on KDE 4.10.1 Xonotic, Super Meat Boy, Battle for Wesnoth runs \
fine.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kwin/composite.cpp <span style="color: grey">(ee885dc)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/109795/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin

[prev in list] [next in list] [prev in thread] [next in thread] 