This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109778/ |
On March 28th, 2013, 3:33 p.m. UTC, Thomas Lübking wrote:
Given with esp. QML the shadows can already be part of the window - what makes this different from Plasma.Dialog other than the bypass windows hint? Ie. what's worth risking to dip into some sort of forked API for kwin only (which actually backrefs plasma, so RazorQt is not an argument ;-) As for the bypass requirement, my initial thought after Michail came up with that for the second time was to just add an abort() into events.cpp or maybe deny management and push out an error message instead.On March 28th, 2013, 4:18 p.m. UTC, Martin Gräßlin wrote:
ah the shadows/translucency is not the reason I did this. That's more a lucky side effect. The things I did this for are not yet implemented. When playing with "Present Windows 2" I noticed the following issues with PlasmaCore Dialog: * it honors panels - good for Plasma, bad for us * it cannot be set to not have a background (we will need that if we want to have transitions from current window positions) * using Qt.Popup to get mouse/keyboard breaks with multi screen. Only one of the window gets the events and clicking outside the dialog (other screen) closes it. * API is difficult to use due to having to set BypassWindowManagerHints and Qt.Popup so what I want to do, is adding properties: * grabMouse * grabKeyboard grabMouse will create a fullscreen input window just like the effects and grabKeyboard uses our normal grab functionality. From events.cpp I would then multicast the events into all currently visible windows. I just don't think we could extend the Plasma API to fit those needs.
> I just don't think we could extend the Plasma API to fit those needs. Well, Marco will have to answer that one ;-) I'd suspect sth. similar would be required for the dashboard and there's also the Homerun launcher (which also has a transparent background) Don't get me wrong, but i'd rather try to get this fixed "upstream" because otherwise we'll never end getting bug reports from script authors trying to invoke Plasma.* (-> abort()) or drifting/running after *cough* last minute changes *cough* for alignment ...
- Thomas
On March 28th, 2013, 3:17 p.m. UTC, Martin Gräßlin wrote:
Review request for kwin and Marco Martin.
By Martin Gräßlin.
Updated March 28, 2013, 3:17 p.m. Description
Diffs
|