[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request 108947: Fix stupid plasma theme workaround
From: "Ralf Jung" <post+kde () ralfj ! de>
Date: 2013-03-28 22:07:27
Message-ID: 20130328220727.14549.91646 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Feb. 14, 2013, 9:21 p.m., Xuetian Weng wrote:
> > kwin/tabbox/qml/ShadowedSvgItem.qml, line 39
> > <http://git.reviewboard.kde.org/r/108947/diff/1/?file=113964#file113964line39>
> >
> > plasmaThemeVariant != "opaque/" should be removed.
> >
> > I think you can try use signal. dynamic property will also have a changed signal, \
> > just add a function called "onNameChanged", name need to be upper case the first \
> > character.
> > I'm not sure it's possible to use onPlasmaThemeVariantChanged here, if not, you \
> > can workaround it with add a new proeprty bind with plasmaThemeVariant, and bind \
> > to this new property here, and directly set the hasElementPrefix("shadow") to \
> > hasNewShadows.
> > or just use onImagePath changed?
>
> Thomas Lübking wrote:
> See above - in doubt i'd just have "plasmaThemeVariant != "reEvaluateMe" && . ;-)
> If this code needs to stay longer but for a workaround hack, that's oc. sth. \
> different.
> Xuetian Weng wrote:
> Yeah, that seems to work.
>
> I don't see further problem if this line changed to
> plasmaThemeVariant != "reEvalulate" || hasElementPrefix("shadow")
I can confirm that this patch fixes issues with the window switched tabboxes using an \
entirely transparent background, which makes the text in there unreadable depending \
on the window behind it (https://bugs.kde.org/show_bug.cgi?id=317238). What's needed \
to let this patch go in? Is adding the mentioned "onNameChanged" hook (or the hack) \
sufficient?
- Ralf
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108947/#review27471
-----------------------------------------------------------
On Feb. 13, 2013, 10:40 p.m., Thomas Lübking wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108947/
> -----------------------------------------------------------
>
> (Updated Feb. 13, 2013, 10:40 p.m.)
>
>
> Review request for kwin, Martin Gräßlin, Sebastian Kügler, and Xuetian Weng.
>
>
> Description
> -------
>
> Needless to say that this should not have happened.
>
> Neither the late push of the new air theme, nor the attempt to workaround the bug \
> chain from Qt over KWindowSystem to Plasma::theme about not catching the \
> compositing state.
>
> This addresses bug 315064.
> http://bugs.kde.org/show_bug.cgi?id=315064
>
>
> Diffs
> -----
>
> kwin/tabbox/declarative.cpp 5beaf1b
> kwin/tabbox/qml/ShadowedSvgItem.qml 8bf76c8
>
> Diff: http://git.reviewboard.kde.org/r/108947/diff/
>
>
> Testing
> -------
>
> Yes. And i hate tabboxes.
>
>
> Thanks,
>
> Thomas Lübking
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/108947/">http://git.reviewboard.kde.org/r/108947/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On February 14th, 2013, 9:21 p.m. CET, <b>Xuetian \
Weng</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/108947/diff/1/?file=113964#file113964line39" \
style="color: black; font-weight: bold; text-decoration: \
underline;">kwin/tabbox/qml/ShadowedSvgItem.qml</a> <span style="font-weight: \
normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">39</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="nx">property</span> <span class="nx">bool</span> <span \
class="k">hasNewShadows:</span> <span class="nx">plasmaThemeVariant</span> <span \
class="o">!=</span> <span class="s2">"opaque/"</span> <span \
class="o">&&</span> <span class="nx">hasElementPrefix</span><span \
class="p">(</span><span class="s2">"shadow"</span><span \
class="p">)</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">plasmaThemeVariant != \
"opaque/" should be removed.
I think you can try use signal. dynamic property will also have a changed signal, \
just add a function called "onNameChanged", name need to be upper case the \
first character.
I'm not sure it's possible to use onPlasmaThemeVariantChanged here, if not, \
you can workaround it with add a new proeprty bind with plasmaThemeVariant, and bind \
to this new property here, and directly set the hasElementPrefix("shadow") \
to hasNewShadows.
or just use onImagePath changed?</pre>
</blockquote>
<p>On February 14th, 2013, 9:45 p.m. CET, <b>Thomas Lübking</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">See above - in doubt \
i'd just have "plasmaThemeVariant != "reEvaluateMe" && . \
;-) If this code needs to stay longer but for a workaround hack, that's oc. sth. \
different.</pre> </blockquote>
<p>On March 6th, 2013, 9:17 p.m. CET, <b>Xuetian Weng</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Yeah, that seems to \
work.
I don't see further problem if this line changed to
plasmaThemeVariant != "reEvalulate" || \
hasElementPrefix("shadow")</pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I can \
confirm that this patch fixes issues with the window switched tabboxes using an \
entirely transparent background, which makes the text in there unreadable depending \
on the window behind it (https://bugs.kde.org/show_bug.cgi?id=317238). What's \
needed to let this patch go in? Is adding the mentioned "onNameChanged" \
hook (or the hack) sufficient?</pre> <br />
<p>- Ralf</p>
<br />
<p>On February 13th, 2013, 10:40 p.m. CET, Thomas Lübking wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin, Martin Gräßlin, Sebastian Kügler, and Xuetian \
Weng.</div> <div>By Thomas Lübking.</div>
<p style="color: grey;"><i>Updated Feb. 13, 2013, 10:40 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Needless to say that this should not have happened.
Neither the late push of the new air theme, nor the attempt to workaround the bug \
chain from Qt over KWindowSystem to Plasma::theme about not catching the compositing \
state.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Yes. And i hate tabboxes.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=315064">315064</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kwin/tabbox/declarative.cpp <span style="color: grey">(5beaf1b)</span></li>
<li>kwin/tabbox/qml/ShadowedSvgItem.qml <span style="color: \
grey">(8bf76c8)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/108947/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic